[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] hw/misc/mips_itu: Remove unnecessary 'exec/exec-all.h' h

From: Thomas Huth
Subject: Re: [PATCH 2/4] hw/misc/mips_itu: Remove unnecessary 'exec/exec-all.h' header
Date: Thu, 14 Dec 2023 17:42:59 +0100
User-agent: Mozilla Thunderbird

On 12/12/2023 12.36, Philippe Mathieu-Daudé wrote:
mips_itu.c only requires declarations from "hw/core/cpu.h"
and "cpu.h". Avoid including the huge "exec/exec-all.h" header.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
  hw/misc/mips_itu.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/misc/mips_itu.c b/hw/misc/mips_itu.c
index 5a83ccc4e8..37aea0e737 100644
--- a/hw/misc/mips_itu.c
+++ b/hw/misc/mips_itu.c
@@ -22,9 +22,10 @@
  #include "qemu/log.h"
  #include "qemu/module.h"
  #include "qapi/error.h"
-#include "exec/exec-all.h"
+#include "hw/core/cpu.h"
  #include "hw/misc/mips_itu.h"
  #include "hw/qdev-properties.h"
+#include "target/mips/cpu.h"
  /* Initialize as 4kB area to fit all 32 cells with default 128B grain.

Reviewed-by: Thomas Huth <thuth@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]