[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/24] target/ppc/mmu_common.c: Move calculation of a value close
|
From: |
BALATON Zoltan |
|
Subject: |
[PATCH 05/24] target/ppc/mmu_common.c: Move calculation of a value closer to its usage |
|
Date: |
Wed, 24 Apr 2024 00:31:15 +0200 (CEST) |
In mmubooke_check_tlb() prot2 is calculated first but only used after
an unrelated check that can return before tha value is used. Move the
calculation after the check, closer to where it is used, to keep them
together and avoid computing it when not needed.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
target/ppc/mmu_common.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
index 751403f1c8..168ff842a5 100644
--- a/target/ppc/mmu_common.c
+++ b/target/ppc/mmu_common.c
@@ -634,12 +634,6 @@ static int mmubooke_check_tlb(CPUPPCState *env,
ppcemb_tlb_t *tlb,
return -1;
}
- if (FIELD_EX64(env->msr, MSR, PR)) {
- prot2 = tlb->prot & 0xF;
- } else {
- prot2 = (tlb->prot >> 4) & 0xF;
- }
-
/* Check the address space */
if ((access_type == MMU_INST_FETCH ?
FIELD_EX64(env->msr, MSR, IR) :
@@ -648,6 +642,11 @@ static int mmubooke_check_tlb(CPUPPCState *env,
ppcemb_tlb_t *tlb,
return -1;
}
+ if (FIELD_EX64(env->msr, MSR, PR)) {
+ prot2 = tlb->prot & 0xF;
+ } else {
+ prot2 = (tlb->prot >> 4) & 0xF;
+ }
*prot = prot2;
if (prot2 & prot_for_access_type(access_type)) {
qemu_log_mask(CPU_LOG_MMU, "%s: good TLB!\n", __func__);
--
2.30.9
- [PATCH 00/24] Misc PPC exception and BookE MMU clean ups, BALATON Zoltan, 2024/04/23
- [PATCH 17/24] target/ppc/mmu_common.c: Replace hard coded constants in ppc_jumbo_xlate(), BALATON Zoltan, 2024/04/23
- [PATCH 05/24] target/ppc/mmu_common.c: Move calculation of a value closer to its usage,
BALATON Zoltan <=
- [PATCH 11/24] target/ppc/mmu_common.c: Split off real mode cases in get_physical_address_wtlb(), BALATON Zoltan, 2024/04/23
- [PATCH 01/24] target/ppc: Fix gen_sc to use correct nip, BALATON Zoltan, 2024/04/23
- [PATCH 09/24] target/ppc/mmu_common.c: Rename get_bat_6xx_tlb(), BALATON Zoltan, 2024/04/23
- [PATCH 16/24] target/ppc/mmu_common.c: Deindent ppc_jumbo_xlate(), BALATON Zoltan, 2024/04/23
- [PATCH 18/24] target/ppc/mmu_common.c: Make get_physical_address_wtlb() static, BALATON Zoltan, 2024/04/23
- [PATCH 10/24] target/ppc/mmu_common.c: Split out BookE cases before checking real mode, BALATON Zoltan, 2024/04/23
- [PATCH 13/24] target/ppc/mmu_common.c: Simplify mmubooke_get_physical_address(), BALATON Zoltan, 2024/04/23
- [PATCH 07/24] target/ppc/mmu_common.c: Drop cases for unimplemented MPC8xx MMU, BALATON Zoltan, 2024/04/23
- [PATCH 19/24] target/ppc: Move mmu_ctx_t definition to mmu_common.c, BALATON Zoltan, 2024/04/23
- [PATCH 08/24] target/ppc/mmu_common.c: Introduce mmu6xx_get_physical_address(), BALATON Zoltan, 2024/04/23