Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

[Aditya Gupta]

Hi Cédric,

> diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h
> > > > index 0229ef3a9a5c..a1b540c3aa9e 100644
> > > > --- a/target/ppc/cpu-models.h
> > > > +++ b/target/ppc/cpu-models.h
> > > > @@ -354,6 +354,7 @@ enum {
> > > >        CPU_POWERPC_POWER10_BASE       = 0x00800000,
> > > >        CPU_POWERPC_POWER10_DD1        = 0x00801100,
> > > >        CPU_POWERPC_POWER10_DD20       = 0x00801200,
> > > > +    CPU_POWERPC_POWER11            = 0x00821200,
> > >
> > > is that a DD2.2 PVR ? If so, It should be mentionned in the definition.
> >
> > Yes, I have kept the last 2 bytes same as P10 DD2. I will mention it
> > above the line I have added it, in v3.
>
> Skiboot reports :
>
> [    0.121234172,6] P11 DD1.00 detected
It is a DD2.0, with major revision = 0x2, and minor revision = 0. Might 
need some change in skiboot. Will post a v3 series with changes.


Thanks,

- Aditya Gupta

> C.