Re: [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type

[Aditya Gupta]

Hi Cédric,

> > Skiboot reports :
> >
> > [    0.121234172,6] P11 DD1.00 detected
> It is a DD2.0, with major revision = 0x2, and minor revision = 0. 
> Might need some change in skiboot. Will post a v3 series with changes.
The issue was in QEMU, not skiboot.


QEMU sets CFAM id for Power10 as DD1.0 (hw/ppc/pnv.c: 2093):

        k->chip_cfam_id = 0x120da04900008000ull; /* P10 DD1.0 (with NX) */

CFAM is same for Power11, and hence for both 'powernv10' and 
'powernv11', skiboot shows DD1.0.

It should be `0x220da04980000000` for DD2.0.

Should I update the CFAM in a separate patch ?


Thanks,

Aditya Gupta


> Thanks,
>
> - Aditya Gupta
>
> > C.