Re: [PATCH 1/2] ppc/pnv: Begin a more complete ADU LPC model for POWER9/10

[Nicholas Piggin]

On Thu May 2, 2024 at 6:47 PM AEST, Cédric Le Goater wrote:
> On 5/1/24 14:39, Nicholas Piggin wrote:
> > On Wed Apr 17, 2024 at 9:25 PM AEST, Cédric Le Goater wrote:
> >> Hello Nick,
> >>
> >> On 4/17/24 13:02, Nicholas Piggin wrote:
> >>> This implements a framework for an ADU unit model.
> >>>
> >>> The ADU unit actually implements XSCOM, which is the bridge between MMIO
> >>> and PIB. However it also includes control and status registers and other
> >>> functions that are exposed as PIB (xscom) registers.
> >>>
> >>> To keep things simple, pnv_xscom.c remains the XSCOM bridge
> >>> implementation, and pnv_adu.c implements the ADU registers and other
> >>> functions.
> >>>
> >>> So far, just the ADU no-op registers in the pnv_xscom.c default handler
> >>> are moved over to the adu model.
> >>>
> >>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> >>> ---
> >>>    include/hw/ppc/pnv_adu.h   |  34 ++++++++++++
> >>>    include/hw/ppc/pnv_chip.h  |   3 +
> >>>    include/hw/ppc/pnv_xscom.h |   6 ++
> >>>    hw/ppc/pnv.c               |  16 ++++++
> >>>    hw/ppc/pnv_adu.c           | 111 +++++++++++++++++++++++++++++++++++++
> >>>    hw/ppc/pnv_xscom.c         |   9 ---
> >>>    hw/ppc/meson.build         |   1 +
> >>>    hw/ppc/trace-events        |   4 ++
> >>>    8 files changed, 175 insertions(+), 9 deletions(-)
> >>>    create mode 100644 include/hw/ppc/pnv_adu.h
> >>>    create mode 100644 hw/ppc/pnv_adu.c
> >>>
> >>> diff --git a/include/hw/ppc/pnv_adu.h b/include/hw/ppc/pnv_adu.h
> >>> new file mode 100644
> >>> index 0000000000..9dc91857a9
> >>> --- /dev/null
> >>> +++ b/include/hw/ppc/pnv_adu.h
> >>> @@ -0,0 +1,34 @@
> >>> +/*
> >>> + * QEMU PowerPC PowerNV Emulation of some ADU behaviour
> >>> + *
> >>> + * Copyright (c) 2024, IBM Corporation.
> >>> + *
> >>> + * SPDX-License-Identifier: LGPL-2.1-or-later
> >>
> >>
> >> Did you mean GPL-2.0-or-later ?
> > 
> > Hey Cedric,
> > 
> > Thanks for reviewing, I've been away so sorry for the late reply.
> > 
> > It just came from one of the headers I copied which was LGPL. But
> > there's really nothing much in it and could find a GPL header to
> > copy. Is GPL-2.0-or-later preferred?
>
> I would since all pnv models are GPL.

Some of pnv is actually LGPL. That's okay I'll change to GPL.

> I think some parts of QEMU were initially LGPL (there used to be
> a library, may be that's the reason ?) and other parts are relaxed
> to LGPL because they are reused in libraries.

Thanks,
Nick