[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 38/61] target/ppc/mmu_common.c: Remove single use local variab
|
From: |
BALATON Zoltan |
|
Subject: |
[PATCH v7 38/61] target/ppc/mmu_common.c: Remove single use local variable |
|
Date: |
Mon, 13 May 2024 01:28:12 +0200 (CEST) |
The ptev variable in ppc6xx_tlb_pte_check() is used only once and just
obfuscates an otherwise clear value. Get rid of it.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
target/ppc/mmu_common.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
index 4ca700e31b..b25c77c618 100644
--- a/target/ppc/mmu_common.c
+++ b/target/ppc/mmu_common.c
@@ -98,13 +98,12 @@ static int ppc6xx_tlb_pte_check(mmu_ctx_t *ctx,
target_ulong pte0,
target_ulong pte1, int h,
MMUAccessType access_type)
{
- int ret, pteh, ptev, pp;
+ int ret, pteh, pp;
ret = -1;
/* Check validity and table match */
- ptev = pte_is_valid(pte0);
pteh = (pte0 >> 6) & 1;
- if (ptev && h == pteh) {
+ if (pte_is_valid(pte0) && h == pteh) {
/* Check vsid & api */
pp = pte1 & 0x00000003;
if ((pte0 & PTE_PTEM_MASK) == ctx->ptem) {
--
2.30.9
- Re: [PATCH v7 35/61] target/ppc: Remove pp_check() and reuse ppc_hash32_pp_prot(), (continued)
- [PATCH v7 37/61] target/ppc/mmu_common.c: Remove single use local variable, BALATON Zoltan, 2024/05/12
- [PATCH v7 39/61] target/ppc/mmu_common.c: Remove another single use local, BALATON Zoltan, 2024/05/12
- [PATCH v7 33/61] target/ppc: Add a function to check for page protection bit, BALATON Zoltan, 2024/05/12
- [PATCH v7 41/61] target/ppc/mmu_common.c: Return directly in ppc6xx_tlb_pte_check(), BALATON Zoltan, 2024/05/12
- [PATCH v7 36/61] target/ppc/mmu_common.c: Remove local name for a constant, BALATON Zoltan, 2024/05/12
- [PATCH v7 38/61] target/ppc/mmu_common.c: Remove single use local variable,
BALATON Zoltan <=
- [PATCH v7 40/61] target/ppc/mmu_common.c: Remove yet another single use local, BALATON Zoltan, 2024/05/12
- [PATCH v7 42/61] target/ppc/mmu_common.c: Simplify ppc6xx_tlb_pte_check(), BALATON Zoltan, 2024/05/12
- [PATCH v7 43/61] target/ppc/mmu_common.c: Remove unused field from mmu_ctx_t, BALATON Zoltan, 2024/05/12
- [PATCH v7 44/61] target/ppc/mmu_common.c: Remove hash field from mmu_ctx_t, BALATON Zoltan, 2024/05/12
- [PATCH v7 51/61] target/ppc: Add function to get protection key for hash32 MMU, BALATON Zoltan, 2024/05/12
- [PATCH v7 52/61] target/ppc/mmu-hash32.c: Inline and remove ppc_hash32_pte_prot(), BALATON Zoltan, 2024/05/12
- [PATCH v7 50/61] target/ppc/mmu_common.c: Remove ptem field from mmu_ctx_t, BALATON Zoltan, 2024/05/12
- [PATCH v7 46/61] target/ppc/mmu_common.c: Convert local variable to bool, BALATON Zoltan, 2024/05/12