[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 48/61] target/ppc/mmu_common.c: Simplify a switch statement
|
From: |
BALATON Zoltan |
|
Subject: |
[PATCH v7 48/61] target/ppc/mmu_common.c: Simplify a switch statement |
|
Date: |
Mon, 13 May 2024 01:28:22 +0200 (CEST) |
In mmu6xx_get_physical_address() the switch handles all cases so the
default is never reached and can be dropped. Also group together cases
which just return -4.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
target/ppc/mmu_common.c | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
index 1a2b4158d5..f38a73464f 100644
--- a/target/ppc/mmu_common.c
+++ b/target/ppc/mmu_common.c
@@ -375,15 +375,6 @@ static int mmu6xx_get_physical_address(CPUPPCState *env,
mmu_ctx_t *ctx,
case ACCESS_INT:
/* Integer load/store : only access allowed */
break;
- case ACCESS_CODE:
- /* No code fetch is allowed in direct-store areas */
- return -4;
- case ACCESS_FLOAT:
- /* Floating point load/store */
- return -4;
- case ACCESS_RES:
- /* lwarx, ldarx or srwcx. */
- return -4;
case ACCESS_CACHE:
/*
* dcba, dcbt, dcbtst, dcbf, dcbi, dcbst, dcbz, or icbi
@@ -393,12 +384,10 @@ static int mmu6xx_get_physical_address(CPUPPCState *env,
mmu_ctx_t *ctx,
*/
ctx->raddr = eaddr;
return 0;
- case ACCESS_EXT:
- /* eciwx or ecowx */
- return -4;
- default:
- qemu_log_mask(CPU_LOG_MMU, "ERROR: instruction should not need address"
- " translation\n");
+ case ACCESS_CODE: /* No code fetch is allowed in direct-store areas */
+ case ACCESS_FLOAT: /* Floating point load/store */
+ case ACCESS_RES: /* lwarx, ldarx or srwcx. */
+ case ACCESS_EXT: /* eciwx or ecowx */
return -4;
}
if ((access_type == MMU_DATA_STORE || ctx->key != 1) &&
--
2.30.9
- [PATCH v7 46/61] target/ppc/mmu_common.c: Convert local variable to bool, (continued)
- [PATCH v7 46/61] target/ppc/mmu_common.c: Convert local variable to bool, BALATON Zoltan, 2024/05/12
- [PATCH v7 45/61] target/ppc/mmu_common.c: Remove nx field from mmu_ctx_t, BALATON Zoltan, 2024/05/12
- [PATCH v7 56/61] target/ppc/mmu_common.c: Rename function parameter, BALATON Zoltan, 2024/05/12
- [PATCH v7 61/61] target/ppc/mmu_common.c: Remove a local variable, BALATON Zoltan, 2024/05/12
- [PATCH v7 57/61] targe/ppc/mmu_common.c: Use defines instead of numeric constants, BALATON Zoltan, 2024/05/12
- [PATCH v7 59/61] target/ppc/mmu_common.c: Stop using ctx in get_bat_6xx_tlb(), BALATON Zoltan, 2024/05/12
- [PATCH v7 47/61] target/ppc/mmu_common.c: Remove single use local variable, BALATON Zoltan, 2024/05/12
- [PATCH v7 53/61] target/ppc/mmu_common.c: Init variable in function that relies on it, BALATON Zoltan, 2024/05/12
- [PATCH v7 54/61] target/ppc/mmu_common.c: Remove key field from mmu_ctx_t, BALATON Zoltan, 2024/05/12
- [PATCH v7 49/61] target/ppc/mmu_common.c: Inline and remove ppc6xx_tlb_pte_check(), BALATON Zoltan, 2024/05/12
- [PATCH v7 48/61] target/ppc/mmu_common.c: Simplify a switch statement,
BALATON Zoltan <=
- [PATCH v7 55/61] target/ppc/mmu_common.c: Stop using ctx in ppc6xx_tlb_check(), BALATON Zoltan, 2024/05/12
- [PATCH v7 60/61] target/ppc/mmu_common.c: Remove mmu_ctx_t, BALATON Zoltan, 2024/05/12
- [PATCH v7 58/61] target/ppc: Remove bat_size_prot(), BALATON Zoltan, 2024/05/12
- Re: [PATCH v7 00/61] Misc PPC exception and BookE MMU clean ups, Nicholas Piggin, 2024/05/18