|
| From: | Richard Henderson |
| Subject: | Re: [PATCH 05/14] target/ppc: Implement attn instruction on BookS 64-bit processors |
| Date: | Sat, 18 May 2024 13:07:35 +0200 |
| User-agent: | Mozilla Thunderbird |
On 5/18/24 11:31, Nicholas Piggin wrote:
+static void gen_attn(DisasContext *ctx)
+{
+#if defined(CONFIG_USER_ONLY)
+ GEN_PRIV(ctx);
+#else
+ gen_helper_attn(tcg_env);
+#endif
+}
You forgot to check priv in system mode.
Better as
GEN_PRIV(ctx);
#ifndef CONFIG_USER_ONLY
gen_helper_attn(...)
#endif
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |