[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 69/72] target/ppc/mmu-radix64.c: Drop a local variable
|
From: |
Nicholas Piggin |
|
Subject: |
[PULL 69/72] target/ppc/mmu-radix64.c: Drop a local variable |
|
Date: |
Fri, 24 May 2024 09:07:42 +1000 |
From: BALATON Zoltan <balaton@eik.bme.hu>
The value is only used once so no need to introduce a local variable
for it.
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
target/ppc/mmu-radix64.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
index fefa55a5f1..c1e4f00335 100644
--- a/target/ppc/mmu-radix64.c
+++ b/target/ppc/mmu-radix64.c
@@ -185,7 +185,6 @@ static bool ppc_radix64_check_prot(PowerPCCPU *cpu,
MMUAccessType access_type,
int mmu_idx, bool partition_scoped)
{
CPUPPCState *env = &cpu->env;
- int need_prot;
/* Check Page Attributes (pte58:59) */
if ((pte & R_PTE_ATT) == R_PTE_ATT_NI_IO && access_type == MMU_INST_FETCH)
{
@@ -210,8 +209,8 @@ static bool ppc_radix64_check_prot(PowerPCCPU *cpu,
MMUAccessType access_type,
}
/* Check if requested access type is allowed */
- need_prot = prot_for_access_type(access_type);
- if (need_prot & ~*prot) { /* Page Protected for that Access */
+ if (prot_for_access_type(access_type) & ~*prot) {
+ /* Page Protected for that Access */
*fault_cause |= access_type == MMU_INST_FETCH ? SRR1_NOEXEC_GUARD :
DSISR_PROTFAULT;
return true;
--
2.43.0
- [PULL 64/72] target/ppc/mmu_common.c: Transform ppc_jumbo_xlate() into ppc_6xx_xlate(), (continued)
- [PULL 64/72] target/ppc/mmu_common.c: Transform ppc_jumbo_xlate() into ppc_6xx_xlate(), Nicholas Piggin, 2024/05/23
- [PULL 60/72] target/ppc/mmu_common.c: Simplify ppc_booke_xlate() part 1, Nicholas Piggin, 2024/05/23
- [PULL 61/72] target/ppc/mmu_common.c: Simplify ppc_booke_xlate() part 2, Nicholas Piggin, 2024/05/23
- [PULL 63/72] target/ppc/mmu_common.c: Split off 40x cases from ppc_jumbo_xlate(), Nicholas Piggin, 2024/05/23
- [PULL 62/72] target/ppc/mmu_common.c: Split off real mode handling from get_physical_address_wtlb(), Nicholas Piggin, 2024/05/23
- [PULL 66/72] target/ppc: Remove id_tlbs flag from CPU env, Nicholas Piggin, 2024/05/23
- [PULL 65/72] target/ppc/mmu_common.c: Move mmu_ctx_t type to mmu_common.c, Nicholas Piggin, 2024/05/23
- [PULL 68/72] target/ppc/mmu-hash32.c: Drop a local variable, Nicholas Piggin, 2024/05/23
- [PULL 67/72] target/ppc: Split off common embedded TLB init, Nicholas Piggin, 2024/05/23
- [PULL 70/72] target/ppc: Add a function to check for page protection bit, Nicholas Piggin, 2024/05/23
- [PULL 69/72] target/ppc/mmu-radix64.c: Drop a local variable,
Nicholas Piggin <=
- [PULL 72/72] target/ppc: Remove pp_check() and reuse ppc_hash32_pp_prot(), Nicholas Piggin, 2024/05/23
- [PULL 71/72] target/ppc: Move out BookE and related MMU functions from mmu_common.c, Nicholas Piggin, 2024/05/23
- Re: [PULL 00/72] ppc-for-9.1-1 queue, Nicholas Piggin, 2024/05/23
- [PULL 00/72] ppc-for-9.1-1 queue, Nicholas Piggin, 2024/05/23