[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 06/43] target/ppc/mmu_common.c: Remove yet another single use loc
|
From: |
BALATON Zoltan |
|
Subject: |
[PATCH 06/43] target/ppc/mmu_common.c: Remove yet another single use local variable |
|
Date: |
Mon, 27 May 2024 01:12:41 +0200 (CEST) |
In ppc6xx_tlb_pte_check() the pp variable is used only once to pass it
to a function parameter with the same name. Remove the local and
inline the value. Also use named constant for the hex value to make it
clearer.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
target/ppc/mmu_common.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
index b21f52290f..799d2ced9b 100644
--- a/target/ppc/mmu_common.c
+++ b/target/ppc/mmu_common.c
@@ -98,13 +98,12 @@ static int ppc6xx_tlb_pte_check(mmu_ctx_t *ctx,
target_ulong pte0,
target_ulong pte1, int pteh,
MMUAccessType access_type)
{
- int ret, pp;
+ int ret;
ret = -1;
/* Check validity and table match */
if (pte_is_valid(pte0) && ((pte0 >> 6) & 1) == pteh) {
/* Check vsid & api */
- pp = pte1 & 0x00000003;
if ((pte0 & PTE_PTEM_MASK) == ctx->ptem) {
if (ctx->raddr != (hwaddr)-1ULL) {
/* all matches should have equal RPN, WIMG & PP */
@@ -115,7 +114,7 @@ static int ppc6xx_tlb_pte_check(mmu_ctx_t *ctx,
target_ulong pte0,
}
/* Keep the matching PTE information */
ctx->raddr = pte1;
- ctx->prot = ppc_hash32_prot(ctx->key, pp, ctx->nx);
+ ctx->prot = ppc_hash32_prot(ctx->key, pte1 & HPTE32_R_PP, ctx->nx);
if (check_prot_access_type(ctx->prot, access_type)) {
/* Access granted */
qemu_log_mask(CPU_LOG_MMU, "PTE access granted !\n");
--
2.30.9
- [PATCH 00/43] Remaining MMU clean up patches, BALATON Zoltan, 2024/05/26
- [PATCH 04/43] target/ppc/mmu_common.c: Remove single use local variable, BALATON Zoltan, 2024/05/26
- [PATCH 03/43] target/ppc/mmu_common.c: Remove single use local variable, BALATON Zoltan, 2024/05/26
- [PATCH 06/43] target/ppc/mmu_common.c: Remove yet another single use local variable,
BALATON Zoltan <=
- [PATCH 08/43] target/ppc/mmu_common.c: Simplify ppc6xx_tlb_pte_check(), BALATON Zoltan, 2024/05/26
- [PATCH 01/43] target/ppc: Reorganise and rename ppc_hash32_pp_prot(), BALATON Zoltan, 2024/05/26
- [PATCH 02/43] target/ppc/mmu_common.c: Remove local name for a constant, BALATON Zoltan, 2024/05/26
- [PATCH 16/43] target/ppc/mmu_common.c: Inline and remove ppc6xx_tlb_pte_check(), BALATON Zoltan, 2024/05/26
- [PATCH 15/43] target/ppc/mmu_common.c: Simplify a switch statement, BALATON Zoltan, 2024/05/26
- [PATCH 18/43] target/ppc: Add function to get protection key for hash32 MMU, BALATON Zoltan, 2024/05/26
- [PATCH 20/43] target/ppc/mmu_common.c: Init variable in function that relies on it, BALATON Zoltan, 2024/05/26
- [PATCH 05/43] target/ppc/mmu_common.c: Remove another single use local variable, BALATON Zoltan, 2024/05/26
- [PATCH 17/43] target/ppc/mmu_common.c: Remove ptem field from mmu_ctx_t, BALATON Zoltan, 2024/05/26
- [PATCH 21/43] target/ppc/mmu_common.c: Remove key field from mmu_ctx_t, BALATON Zoltan, 2024/05/26