[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 02/43] target/ppc/mmu_common.c: Remove local name for a constant
|
From: |
BALATON Zoltan |
|
Subject: |
[PATCH 02/43] target/ppc/mmu_common.c: Remove local name for a constant |
|
Date: |
Mon, 27 May 2024 01:12:37 +0200 (CEST) |
The mmask local variable is a less descriptive local name for a
constant. Drop it and use the constant directly in the two places it
is needed.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
target/ppc/mmu_common.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
index 08c5b61f76..2618cdec6a 100644
--- a/target/ppc/mmu_common.c
+++ b/target/ppc/mmu_common.c
@@ -98,7 +98,7 @@ static int ppc6xx_tlb_pte_check(mmu_ctx_t *ctx, target_ulong
pte0,
target_ulong pte1, int h,
MMUAccessType access_type)
{
- target_ulong ptem, mmask;
+ target_ulong ptem;
int ret, pteh, ptev, pp;
ret = -1;
@@ -108,12 +108,11 @@ static int ppc6xx_tlb_pte_check(mmu_ctx_t *ctx,
target_ulong pte0,
if (ptev && h == pteh) {
/* Check vsid & api */
ptem = pte0 & PTE_PTEM_MASK;
- mmask = PTE_CHECK_MASK;
pp = pte1 & 0x00000003;
if (ptem == ctx->ptem) {
if (ctx->raddr != (hwaddr)-1ULL) {
/* all matches should have equal RPN, WIMG & PP */
- if ((ctx->raddr & mmask) != (pte1 & mmask)) {
+ if ((ctx->raddr & PTE_CHECK_MASK) != (pte1 & PTE_CHECK_MASK)) {
qemu_log_mask(CPU_LOG_MMU, "Bad RPN/WIMG/PP\n");
return -3;
}
--
2.30.9
- [PATCH 00/43] Remaining MMU clean up patches, BALATON Zoltan, 2024/05/26
- [PATCH 04/43] target/ppc/mmu_common.c: Remove single use local variable, BALATON Zoltan, 2024/05/26
- [PATCH 03/43] target/ppc/mmu_common.c: Remove single use local variable, BALATON Zoltan, 2024/05/26
- [PATCH 06/43] target/ppc/mmu_common.c: Remove yet another single use local variable, BALATON Zoltan, 2024/05/26
- [PATCH 08/43] target/ppc/mmu_common.c: Simplify ppc6xx_tlb_pte_check(), BALATON Zoltan, 2024/05/26
- [PATCH 01/43] target/ppc: Reorganise and rename ppc_hash32_pp_prot(), BALATON Zoltan, 2024/05/26
- [PATCH 02/43] target/ppc/mmu_common.c: Remove local name for a constant,
BALATON Zoltan <=
- [PATCH 16/43] target/ppc/mmu_common.c: Inline and remove ppc6xx_tlb_pte_check(), BALATON Zoltan, 2024/05/26
- [PATCH 15/43] target/ppc/mmu_common.c: Simplify a switch statement, BALATON Zoltan, 2024/05/26
- [PATCH 18/43] target/ppc: Add function to get protection key for hash32 MMU, BALATON Zoltan, 2024/05/26
- [PATCH 20/43] target/ppc/mmu_common.c: Init variable in function that relies on it, BALATON Zoltan, 2024/05/26
- [PATCH 05/43] target/ppc/mmu_common.c: Remove another single use local variable, BALATON Zoltan, 2024/05/26
- [PATCH 17/43] target/ppc/mmu_common.c: Remove ptem field from mmu_ctx_t, BALATON Zoltan, 2024/05/26
- [PATCH 21/43] target/ppc/mmu_common.c: Remove key field from mmu_ctx_t, BALATON Zoltan, 2024/05/26
- [PATCH 24/43] target/ppc/mmu_common.c: Use defines instead of numeric constants, BALATON Zoltan, 2024/05/26
- [PATCH 07/43] target/ppc/mmu_common.c: Return directly in ppc6xx_tlb_pte_check(), BALATON Zoltan, 2024/05/26
- [PATCH 09/43] target/ppc/mmu_common.c: Remove unused field from mmu_ctx_t, BALATON Zoltan, 2024/05/26