[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/43] target/ppc/mmu_common.c: Remove another single use local v
|
From: |
BALATON Zoltan |
|
Subject: |
[PATCH 05/43] target/ppc/mmu_common.c: Remove another single use local variable |
|
Date: |
Mon, 27 May 2024 01:12:40 +0200 (CEST) |
In ppc6xx_tlb_pte_check() the pteh variable is used only once to
compare to the h parameter of the function. Inline its value and use
pteh name for the function parameter which is more descriptive.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
target/ppc/mmu_common.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
index 16578f7fa5..b21f52290f 100644
--- a/target/ppc/mmu_common.c
+++ b/target/ppc/mmu_common.c
@@ -95,15 +95,14 @@ int ppc6xx_tlb_getnum(CPUPPCState *env, target_ulong eaddr,
}
static int ppc6xx_tlb_pte_check(mmu_ctx_t *ctx, target_ulong pte0,
- target_ulong pte1, int h,
+ target_ulong pte1, int pteh,
MMUAccessType access_type)
{
- int ret, pteh, pp;
+ int ret, pp;
ret = -1;
/* Check validity and table match */
- pteh = (pte0 >> 6) & 1;
- if (pte_is_valid(pte0) && h == pteh) {
+ if (pte_is_valid(pte0) && ((pte0 >> 6) & 1) == pteh) {
/* Check vsid & api */
pp = pte1 & 0x00000003;
if ((pte0 & PTE_PTEM_MASK) == ctx->ptem) {
--
2.30.9
- [PATCH 04/43] target/ppc/mmu_common.c: Remove single use local variable, (continued)
- [PATCH 04/43] target/ppc/mmu_common.c: Remove single use local variable, BALATON Zoltan, 2024/05/26
- [PATCH 03/43] target/ppc/mmu_common.c: Remove single use local variable, BALATON Zoltan, 2024/05/26
- [PATCH 06/43] target/ppc/mmu_common.c: Remove yet another single use local variable, BALATON Zoltan, 2024/05/26
- [PATCH 08/43] target/ppc/mmu_common.c: Simplify ppc6xx_tlb_pte_check(), BALATON Zoltan, 2024/05/26
- [PATCH 01/43] target/ppc: Reorganise and rename ppc_hash32_pp_prot(), BALATON Zoltan, 2024/05/26
- [PATCH 02/43] target/ppc/mmu_common.c: Remove local name for a constant, BALATON Zoltan, 2024/05/26
- [PATCH 16/43] target/ppc/mmu_common.c: Inline and remove ppc6xx_tlb_pte_check(), BALATON Zoltan, 2024/05/26
- [PATCH 15/43] target/ppc/mmu_common.c: Simplify a switch statement, BALATON Zoltan, 2024/05/26
- [PATCH 18/43] target/ppc: Add function to get protection key for hash32 MMU, BALATON Zoltan, 2024/05/26
- [PATCH 20/43] target/ppc/mmu_common.c: Init variable in function that relies on it, BALATON Zoltan, 2024/05/26
- [PATCH 05/43] target/ppc/mmu_common.c: Remove another single use local variable,
BALATON Zoltan <=
- [PATCH 17/43] target/ppc/mmu_common.c: Remove ptem field from mmu_ctx_t, BALATON Zoltan, 2024/05/26
- [PATCH 21/43] target/ppc/mmu_common.c: Remove key field from mmu_ctx_t, BALATON Zoltan, 2024/05/26
- [PATCH 24/43] target/ppc/mmu_common.c: Use defines instead of numeric constants, BALATON Zoltan, 2024/05/26
- [PATCH 07/43] target/ppc/mmu_common.c: Return directly in ppc6xx_tlb_pte_check(), BALATON Zoltan, 2024/05/26
- [PATCH 09/43] target/ppc/mmu_common.c: Remove unused field from mmu_ctx_t, BALATON Zoltan, 2024/05/26
- [PATCH 10/43] target/ppc/mmu_common.c: Remove hash field from mmu_ctx_t, BALATON Zoltan, 2024/05/26
- [PATCH 27/43] target/ppc/mmu_common.c: Remove mmu_ctx_t, BALATON Zoltan, 2024/05/26
- [PATCH 30/43] target/ppc: Unexport some functions from mmu-book3s-v3.h, BALATON Zoltan, 2024/05/26
- [PATCH 33/43] target/ppc: Remove single use static inline function, BALATON Zoltan, 2024/05/26
- [PATCH 11/43] target/ppc/mmu_common.c: Remove pte_update_flags(), BALATON Zoltan, 2024/05/26