Re: [PATCH] vfio: container: Fix missing allocation of VFIOSpaprContainer

[Shivaprasad G Bhat]

Hi Cédric,

On 6/20/24 6:37 PM, Cédric Le Goater wrote:
> Shivaprasad,
>
> On 5/9/24 9:14 PM, Shivaprasad G Bhat wrote:
> > The commit 6ad359ec29 "(vfio/spapr: Move prereg_listener into
> > spapr container)" began to use the newly introduced VFIOSpaprContainer
> > structure.
> >
> > After several refactors, today the container_of(container,
> > VFIOSpaprContainer, ABC) is used when VFIOSpaprContainer is actually
> > not allocated. On PPC64 systems, this dereference is leading to 
> > corruption
> > showing up as glibc malloc assertion during guest start when using vfio.
> >
> > Patch adds the missing allocation while also making the structure 
> > movement
> > to vfio common header file.
> >
> > Fixes: 6ad359ec29 "(vfio/spapr: Move prereg_listener into spapr 
> > container)"
> > Signed-off-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
>
> Could you please give vfio-9.1 a try ? Thanks,
Yes. This is working fine for ppc64.


Thank you!


Regards,

Shivaprasad


> C.
>
> https://github.com/legoater/qemu/commits/vfio-9.1
<snip>