[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-riscv] [PULL 1/3] target/riscv/pmp.c: pmpcfg_csr_read returns bogu

From: Palmer Dabbelt
Subject: [Qemu-riscv] [PULL 1/3] target/riscv/pmp.c: pmpcfg_csr_read returns bogus value on RV64
Date: Thu, 1 Nov 2018 16:55:23 -0700

From: Dayeol Lee <address@hidden>

pmp_read_cfg() returns 8-bit value, which is combined together to form a single 
pmpcfg CSR.
The default promotion rules will result in an integer here ("i*8" is integer, 
flows through) resulting in a 32-bit signed value on most hosts.
That's bogus on RV64I, with the high bits of the CSR being wrong.

Signed-off-by: Dayeol Lee <address@hidden>
Reviewed-by: Palmer Dabbelt <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Signed-off-by: Palmer Dabbelt <address@hidden>
 target/riscv/pmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c
index f432f3b7594b..03abd8fe5eb7 100644
--- a/target/riscv/pmp.c
+++ b/target/riscv/pmp.c
@@ -325,7 +325,7 @@ target_ulong pmpcfg_csr_read(CPURISCVState *env, uint32_t 
     int i;
     target_ulong cfg_val = 0;
-    uint8_t val = 0;
+    target_ulong val = 0;
     for (i = 0; i < sizeof(target_ulong); i++) {
         val = pmp_read_cfg(env, (reg_index * sizeof(target_ulong)) + i);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]