[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-riscv] [PATCH for-3.2 v7 1/6] hw/riscv/virt: Increase the numb

From: Logan Gunthorpe
Subject: Re: [Qemu-riscv] [PATCH for-3.2 v7 1/6] hw/riscv/virt: Increase the number of interrupts
Date: Wed, 21 Nov 2018 12:02:24 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 2018-11-21 11:59 a.m., Alistair Francis wrote:
> On Wed, Nov 21, 2018 at 10:56 AM Logan Gunthorpe <address@hidden> wrote:
>> On 2018-11-21 11:49 a.m., Alistair Francis wrote:
>>> Agreed. It's the same number as the last interrupt in the QEMU SiFive
>>> U machine. So that is where it came from.
>> Ok, can we have a comment for that?
> I don't think we really need a comment. It's just a made up number. It
> just has to be higher then the actual number of used interrupts. It
> can be changed in the future if required.

If it's confusing to me it'll be confusing to others reading it. At
least put something in the commit log describing the choice of number
and why it's not important...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]