[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-riscv] [Qemu-devel] [PATCH for-3.1 1/2] MAINTAINERS: Any file
Re: [Qemu-riscv] [Qemu-devel] [PATCH for-3.1 1/2] MAINTAINERS: Any file with "riscv" in the name is a RISC-V file
Thu, 22 Nov 2018 10:09:16 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
On 2018-11-22 02:44, Palmer Dabbelt wrote:
> On Wed, 21 Nov 2018 16:29:09 PST (-0800), address@hidden wrote:
>> On 22/11/18 0:46, Palmer Dabbelt wrote:
>>> There was a recent thread about unmaintained files in QEMU where it was
>>> noted that a few RISC-V related files had slipped through the patterns
>>> in our MAINTAINERS file entry. This patch adds some more aggressive
>>> pattern matching in an attempt to rectify this situation.
>>> Signed-off-by: Palmer Dabbelt <address@hidden>
>>> MAINTAINERS | 2 ++
>>> 1 file changed, 2 insertions(+)
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 1032406c5607..e89adc81d5d5 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -255,6 +255,8 @@ F: target/riscv/
>>> F: hw/riscv/
>>> F: include/hw/riscv/
>>> F: disas/riscv.c
>>> +K: riscv
Please be very careful with the "K:" lines ... you could suddenly end up
being a "maintainer" for files that you did not expect. For example,
after applying your patch, I guess the following commands will tell you
that you're the maintainer of these files:
script/get_maintainer.pl -f MAINTAINERS
script/get_maintainer.pl -f qapi/misc.json
script/get_maintainer.pl -f configure
For this reason, we've limited the "K:" lines in MAINTAINERS so far to
files that contain the regex "^Subject:", too (so that they only match
patches with the keyword in the subject).
>>> +N: riscv
>> QEMU doesn't support the 'N' tag.
>> I see from the Linux kernel:
>> N: Files and directories with regex patterns.
>> N: [^a-z]tegra all files whose path contains the word tegra
>> One pattern per line. Multiple N: lines acceptable.
>> scripts/get_maintainer.pl has different behavior for files that
>> match F: pattern and matches of N: patterns. By default,
>> get_maintainer will not look at git log history when an F: pattern
>> match occurs. When an N: match occurs, git log history is used
>> to also notify the people that have git commit signatures.
>> Should we add this feature to checkscript?
> Ah, I didn't check because I just copied this from our Linux entry.
> It's pretty much the core of what I'm trying to do here so if it's easy
> then that'd be great.
> Unfortunately I don't know how to do so.
Try to export the commits eb90d0855 and bbbe96ed8 from the Linux kernel
git and see whether the patches can be applied to our version of