[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-riscv] [Qemu-devel] [PATCH 5/5 v3] RISC-V: Add hooks to use th

From: Palmer Dabbelt
Subject: Re: [Qemu-riscv] [Qemu-devel] [PATCH 5/5 v3] RISC-V: Add hooks to use the gdb xml files.
Date: Mon, 11 Feb 2019 10:17:41 -0800 (PST)

On Fri, 08 Feb 2019 11:28:48 PST (-0800), address@hidden wrote:
On Fri, Feb 8, 2019 at 11:09 AM Jim Wilson <address@hidden> wrote:

On Fri, Feb 8, 2019 at 10:17 AM Alistair Francis <address@hidden> wrote:
> Can we just write a wrapper function then that sets and unsets the variable?
> Something like this:
> riscv_csrrw_debug(...) {
>     #if !defined(CONFIG_USER_ONLY)
>             env->debugger = true;
>     #endif
>             result = riscv_csrrw(env, ...);
>     #if !defined(CONFIG_USER_ONLY)
>             env->debugger = false;
>     #endif
> }

Yes, that would work.  Do you want me to resubmit a fixed part 5 patch?

It's probably best to send out a new version of the whole series.
Include all the Reviewed-by tags and then that should be the last
version and Palmer can apply that series directly.

Ya, that's the best way to do it. That way everyone is on the same page about exactly what is going in.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]