[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-riscv] [Qemu-devel] [PATCH] SiFive RISC-V GPIO Device

From: Palmer Dabbelt
Subject: Re: [Qemu-riscv] [Qemu-devel] [PATCH] SiFive RISC-V GPIO Device
Date: Wed, 13 Feb 2019 12:14:56 -0800 (PST)

On Wed, 13 Feb 2019 10:54:08 PST (-0800), address@hidden wrote:
On 2019-02-13 18:14, Peter Maydell wrote:
On Wed, 13 Feb 2019 at 00:13, Alistair Francis <address@hidden> wrote:
I know the other RISC-V files don't do it, but this should go in the
hw/gpio directory instead of hw/riscv.

It might be nice to move those existing riscv devices into
their proper places at some point: should be a fairly easy
cleanup patch if somebody wants to take it on. (Advice
on what should live where available on request.)

If devices only work on riscv, they should IMHO stay in hw/riscv/. I
think hw/gpio/ and friends should primarily be used if a device is
shared between architectures. If they stay in hw/riscv/ it is way easier
to match the devices with wildcards in the MAINTAINERS file. Just my
0.02 € only, of course.

FWIW, I generally consider things like SiFive's GPIO controller to have nothing to do with RISC-V and therefor don't belong in hw/riscv. That said, I don't really care that much so I'm happy with pretty much any source code organization that works for everyone else. Let me know if we should move them around.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]