Re: [Qemu-riscv] [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2d38a32cd2 target/riscv: Remaining rvc insn reuse 32 bit translators
f78e38076d target/riscv: Splice remaining compressed insn pairs for riscv32 vs 
riscv64
c44e532fe8 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64
0b27c4efb5 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns
bfbca08977 target/riscv: Convert @cs_2 insns to share translation functions
817c810259 target/riscv: Remove decode_RV32_64G()
d449051b86 target/riscv: Remove gen_system()
02c282a707 target/riscv: Rename trans_arith to gen_arith
da08d4630c target/riscv: Remove manual decoding of RV32/64M insn
c26a73f1eb target/riscv: Remove shift and slt insn manual decoding
c813653652 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists
889b9a3ac1 target/riscv: Move gen_arith_imm() decoding into trans_* functions
575eaddbf9 target/riscv: Remove manual decoding from gen_store()
bc35db457c target/riscv: Remove manual decoding from gen_load()
9137c358aa target/riscv: Remove manual decoding from gen_branch()
733ba16e7a target/riscv: Remove gen_jalr()
65e9687470 target/riscv: Convert quadrant 2 of RVXC insns to decodetree
014865a06b target/riscv: Convert quadrant 1 of RVXC insns to decodetree
07cbd2eee2 target/riscv: Convert quadrant 0 of RVXC insns to decodetree
f5ea50b3f9 target/riscv: Convert RV priv insns to decodetree
f174857a8d target/riscv: Convert RV64D insns to decodetree
8addf378cc target/riscv: Convert RV32D insns to decodetree
08dc5b9219 target/riscv: Convert RV64F insns to decodetree
cab5e5b87d target/riscv: Convert RV32F insns to decodetree
d900682426 target/riscv: Convert RV64A insns to decodetree
1b32036a98 target/riscv: Convert RV32A insns to decodetree
79f6f5dae7 target/riscv: Convert RVXM insns to decodetree
39012e5d62 target/riscv: Convert RVXI csr insns to decodetree
e5360a38b0 target/riscv: Convert RVXI fence insns to decodetree
723fc1625b target/riscv: Convert RVXI arithmetic insns to decodetree
3d54710b38 target/riscv: Convert RV64I load/store insns to decodetree
67861de31a target/riscv: Convert RV32I load/store insns to decodetree
770f72af73 target/riscv: Convert RVXI branch insns to decodetree
d72e61d38a target/riscv: Activate decodetree and implemnt LUI & AUIPC

=== OUTPUT BEGIN ===
1/34 Checking commit d72e61d38a1a (target/riscv: Activate decodetree and 
implemnt LUI & AUIPC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

ERROR: externs should be avoided in .c files
#125: FILE: target/riscv/translate.c:1884:
+bool decode_insn32(DisasContext *ctx, uint32_t insn);

total: 1 errors, 1 warnings, 125 lines checked

Patch 1/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/34 Checking commit 770f72af73af (target/riscv: Convert RVXI branch insns to 
decodetree)
3/34 Checking commit 67861de31a54 (target/riscv: Convert RV32I load/store insns 
to decodetree)
4/34 Checking commit 3d54710b3803 (target/riscv: Convert RV64I load/store insns 
to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 4/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/34 Checking commit 723fc1625b3e (target/riscv: Convert RVXI arithmetic insns 
to decodetree)
6/34 Checking commit e5360a38b093 (target/riscv: Convert RVXI fence insns to 
decodetree)
7/34 Checking commit 39012e5d6288 (target/riscv: Convert RVXI csr insns to 
decodetree)
8/34 Checking commit 79f6f5dae7cb (target/riscv: Convert RVXM insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 169 lines checked

Patch 8/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/34 Checking commit 1b32036a98a6 (target/riscv: Convert RV32A insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 9/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/34 Checking commit d900682426a1 (target/riscv: Convert RV64A insns to 
decodetree)
11/34 Checking commit cab5e5b87d6e (target/riscv: Convert RV32F insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 11/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/34 Checking commit 08dc5b92193b (target/riscv: Convert RV64F insns to 
decodetree)
13/34 Checking commit 8addf378cc61 (target/riscv: Convert RV32D insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 13/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/34 Checking commit f174857a8d0e (target/riscv: Convert RV64D insns to 
decodetree)
15/34 Checking commit f5ea50b3f9a4 (target/riscv: Convert RV priv insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 214 lines checked

Patch 15/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/34 Checking commit 07cbd2eee20d (target/riscv: Convert quadrant 0 of RVXC 
insns to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

ERROR: externs should be avoided in .c files
#251: FILE: target/riscv/translate.c:1072:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 231 lines checked

Patch 16/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/34 Checking commit 014865a06bc3 (target/riscv: Convert quadrant 1 of RVXC 
insns to decodetree)
18/34 Checking commit 65e9687470d0 (target/riscv: Convert quadrant 2 of RVXC 
insns to decodetree)
19/34 Checking commit 733ba16e7ae3 (target/riscv: Remove gen_jalr())
20/34 Checking commit 9137c358aa1f (target/riscv: Remove manual decoding from 
gen_branch())
21/34 Checking commit bc35db457cc6 (target/riscv: Remove manual decoding from 
gen_load())
22/34 Checking commit 575eaddbf907 (target/riscv: Remove manual decoding from 
gen_store())
23/34 Checking commit 889b9a3ac1aa (target/riscv: Move gen_arith_imm() decoding 
into trans_* functions)
24/34 Checking commit c813653652e7 (target/riscv: make ADD/SUB/OR/XOR/AND insn 
use arg lists)
25/34 Checking commit c26a73f1ebbe (target/riscv: Remove shift and slt insn 
manual decoding)
26/34 Checking commit da08d4630ce4 (target/riscv: Remove manual decoding of 
RV32/64M insn)
27/34 Checking commit 02c282a70757 (target/riscv: Rename trans_arith to 
gen_arith)
28/34 Checking commit d449051b86ce (target/riscv: Remove gen_system())
29/34 Checking commit 817c810259f5 (target/riscv: Remove decode_RV32_64G())
30/34 Checking commit bfbca089774f (target/riscv: Convert @cs_2 insns to share 
translation functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

ERROR: externs should be avoided in .c files
#182: FILE: target/riscv/translate.c:548:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 164 lines checked

Patch 30/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

31/34 Checking commit 0b27c4efb545 (target/riscv: Convert @cl_d, @cl_w, @cs_d, 
@cs_w insns)
32/34 Checking commit c44e532fe846 (target/riscv: Splice fsw_sd and flw_ld for 
riscv32 vs riscv64)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 309 lines checked

Patch 32/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/34 Checking commit f78e38076d67 (target/riscv: Splice remaining compressed 
insn pairs for riscv32 vs riscv64)
34/34 Checking commit 2d38a32cd249 (target/riscv: Remaining rvc insn reuse 32 
bit translators)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden