Re: [Qemu-riscv] [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
c2c69aa251 target/riscv: Remaining rvc insn reuse 32 bit translators
9a318148d1 target/riscv: Splice remaining compressed insn pairs for riscv32 vs 
riscv64
eeeb834db3 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64
b016042b0a target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns
cb2dec98be target/riscv: Convert @cs_2 insns to share translation functions
ff0c910b57 target/riscv: Remove decode_RV32_64G()
927d960855 target/riscv: Remove gen_system()
2e0ac36052 target/riscv: Rename trans_arith to gen_arith
f44b0d8f40 target/riscv: Remove manual decoding of RV32/64M insn
1ea92eefa9 target/riscv: Remove shift and slt insn manual decoding
9498f1127e target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists
3dfa4c4c4c target/riscv: Move gen_arith_imm() decoding into trans_* functions
0655e2906a target/riscv: Remove manual decoding from gen_store()
fcdae66c13 target/riscv: Remove manual decoding from gen_load()
c6ee42b012 target/riscv: Remove manual decoding from gen_branch()
049e24ff90 target/riscv: Remove gen_jalr()
fece7c1586 target/riscv: Convert quadrant 2 of RVXC insns to decodetree
c34654aade target/riscv: Convert quadrant 1 of RVXC insns to decodetree
bf271dccd0 target/riscv: Convert quadrant 0 of RVXC insns to decodetree
3fd0fe5807 target/riscv: Convert RV priv insns to decodetree
947553ce03 target/riscv: Convert RV64D insns to decodetree
0244c4e5ca target/riscv: Convert RV32D insns to decodetree
2facd2733c target/riscv: Convert RV64F insns to decodetree
efa4b868cc target/riscv: Convert RV32F insns to decodetree
cab479143a target/riscv: Convert RV64A insns to decodetree
ea955e80aa target/riscv: Convert RV32A insns to decodetree
62ab9b09e5 target/riscv: Convert RVXM insns to decodetree
36114883eb target/riscv: Convert RVXI csr insns to decodetree
c005651841 target/riscv: Convert RVXI fence insns to decodetree
846964b556 target/riscv: Convert RVXI arithmetic insns to decodetree
9d969e37b0 target/riscv: Convert RV64I load/store insns to decodetree
847d9c0582 target/riscv: Convert RV32I load/store insns to decodetree
b4b1e9df59 target/riscv: Convert RVXI branch insns to decodetree
919230eab3 target/riscv: Activate decodetree and implemnt LUI & AUIPC

=== OUTPUT BEGIN ===
1/34 Checking commit 919230eab384 (target/riscv: Activate decodetree and 
implemnt LUI & AUIPC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

ERROR: externs should be avoided in .c files
#125: FILE: target/riscv/translate.c:1884:
+bool decode_insn32(DisasContext *ctx, uint32_t insn);

total: 1 errors, 1 warnings, 125 lines checked

Patch 1/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/34 Checking commit b4b1e9df59b8 (target/riscv: Convert RVXI branch insns to 
decodetree)
3/34 Checking commit 847d9c058244 (target/riscv: Convert RV32I load/store insns 
to decodetree)
4/34 Checking commit 9d969e37b044 (target/riscv: Convert RV64I load/store insns 
to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 4/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/34 Checking commit 846964b55682 (target/riscv: Convert RVXI arithmetic insns 
to decodetree)
6/34 Checking commit c005651841a7 (target/riscv: Convert RVXI fence insns to 
decodetree)
7/34 Checking commit 36114883ebb6 (target/riscv: Convert RVXI csr insns to 
decodetree)
8/34 Checking commit 62ab9b09e53a (target/riscv: Convert RVXM insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 169 lines checked

Patch 8/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/34 Checking commit ea955e80aab8 (target/riscv: Convert RV32A insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 9/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/34 Checking commit cab479143aff (target/riscv: Convert RV64A insns to 
decodetree)
11/34 Checking commit efa4b868ccf1 (target/riscv: Convert RV32F insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 11/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/34 Checking commit 2facd2733cfb (target/riscv: Convert RV64F insns to 
decodetree)
13/34 Checking commit 0244c4e5ca8b (target/riscv: Convert RV32D insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 13/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/34 Checking commit 947553ce034a (target/riscv: Convert RV64D insns to 
decodetree)
15/34 Checking commit 3fd0fe580789 (target/riscv: Convert RV priv insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 214 lines checked

Patch 15/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/34 Checking commit bf271dccd014 (target/riscv: Convert quadrant 0 of RVXC 
insns to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

ERROR: externs should be avoided in .c files
#251: FILE: target/riscv/translate.c:1072:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 231 lines checked

Patch 16/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/34 Checking commit c34654aade41 (target/riscv: Convert quadrant 1 of RVXC 
insns to decodetree)
18/34 Checking commit fece7c1586e0 (target/riscv: Convert quadrant 2 of RVXC 
insns to decodetree)
19/34 Checking commit 049e24ff90dc (target/riscv: Remove gen_jalr())
20/34 Checking commit c6ee42b0124d (target/riscv: Remove manual decoding from 
gen_branch())
21/34 Checking commit fcdae66c1343 (target/riscv: Remove manual decoding from 
gen_load())
22/34 Checking commit 0655e2906aed (target/riscv: Remove manual decoding from 
gen_store())
23/34 Checking commit 3dfa4c4c4c81 (target/riscv: Move gen_arith_imm() decoding 
into trans_* functions)
24/34 Checking commit 9498f1127ef7 (target/riscv: make ADD/SUB/OR/XOR/AND insn 
use arg lists)
25/34 Checking commit 1ea92eefa95d (target/riscv: Remove shift and slt insn 
manual decoding)
26/34 Checking commit f44b0d8f40a3 (target/riscv: Remove manual decoding of 
RV32/64M insn)
27/34 Checking commit 2e0ac36052ad (target/riscv: Rename trans_arith to 
gen_arith)
28/34 Checking commit 927d96085513 (target/riscv: Remove gen_system())
29/34 Checking commit ff0c910b57bc (target/riscv: Remove decode_RV32_64G())
30/34 Checking commit cb2dec98bed8 (target/riscv: Convert @cs_2 insns to share 
translation functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

ERROR: externs should be avoided in .c files
#182: FILE: target/riscv/translate.c:548:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 164 lines checked

Patch 30/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

31/34 Checking commit b016042b0a1f (target/riscv: Convert @cl_d, @cl_w, @cs_d, 
@cs_w insns)
32/34 Checking commit eeeb834db343 (target/riscv: Splice fsw_sd and flw_ld for 
riscv32 vs riscv64)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 309 lines checked

Patch 32/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/34 Checking commit 9a318148d1f6 (target/riscv: Splice remaining compressed 
insn pairs for riscv32 vs riscv64)
34/34 Checking commit c2c69aa251b3 (target/riscv: Remaining rvc insn reuse 32 
bit translators)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden