[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-riscv] [Qemu-devel] [PATCH] riscv: virt: Correct pci "bus-rang
Re: [Qemu-riscv] [Qemu-devel] [PATCH] riscv: virt: Correct pci "bus-range" encoding
Thu, 30 May 2019 11:36:46 +0800
On Thu, May 30, 2019 at 11:14 AM Alistair Francis <address@hidden> wrote:
> On Wed, May 29, 2019 at 1:52 AM Bin Meng <address@hidden> wrote:
> > The largest pci bus number should be calculated from ECAM size,
> > instead of its base address.
> > Signed-off-by: Bin Meng <address@hidden>
> This seems ok, can you maybe explain what this fixes?
The logic is wrong, as the commit message said. With current wrong
logic, the largest pci bus number encoded in "bus-ranges" property was
wrongly set to 0x2ff in this case. Per pci spec, the bus number should
not exceed 0xff.