RE: [PATCH v2 0/2] RTC support for QEMU RISC-V virt machine

[Anup Patel]

> -----Original Message-----
> From: Philippe Mathieu-Daudé <address@hidden>
> Sent: Tuesday, September 24, 2019 7:35 PM
> To: Anup Patel <address@hidden>; Peter Maydell
> <address@hidden>; Palmer Dabbelt <address@hidden>; Alistair
> Francis <address@hidden>; Sagar Karandikar
> <address@hidden>; Bastian Koppelmann <address@hidden-
> paderborn.de>
> Cc: Atish Patra <address@hidden>; address@hidden; qemu-
> address@hidden; Anup Patel <address@hidden>
> Subject: Re: [PATCH v2 0/2] RTC support for QEMU RISC-V virt machine
> 
> Hi Anup,
> 
> On 9/24/19 3:11 PM, Anup Patel wrote:
> > This series adds RTC device to QEMU RISC-V virt machine. We have
> > selected Goldfish RTC device model for this. It's a pretty simple
> > synthetic device with few MMIO registers and no dependency external
> > clock. The driver for Goldfish RTC is already available in Linux so we
> > just need to enable it in Kconfig for RISCV and also update Linux
> > defconfigs.
> >
> > We have tested this series with Linux-5.3 plus defconfig changes
> > available in 'goldfish_rtc_v1' branch of:
> > https://github.com/avpatel/linux.git
> >
> > Changes since v1:
> >  - Removed redundant object properties from Goldfish RTC emulation
> >  - Added vmstate for Goldfish RTC
> >
> > Anup Patel (2):
> >   hw: timer: Add Goldfish RTC device
> >   riscv: virt: Use Goldfish RTC device
> >
> >  hw/riscv/Kconfig                |   1 +
> >  hw/riscv/virt.c                 |  15 ++
> >  hw/timer/Kconfig                |   3 +
> >  hw/timer/Makefile.objs          |   1 +
> >  hw/timer/goldfish_rtc.c         | 278
> ++++++++++++++++++++++++++++++++
> >  include/hw/riscv/virt.h         |   2 +
> >  include/hw/timer/goldfish_rtc.h |  46 ++++++
> 
> Minor comment, if my ongoing series "Split RTC devices from hw/timer/ to
> hw/rtc/" is accepted, you'd have to rebase this in hw/rtc/goldfish_rtc:
> https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03334.html
> (no logical change involved).

No problem, I will rebase these patches once your series after it is
accepted.

Regards,
Anup