[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core
|
From: |
Joaquin de Andres |
|
Subject: |
Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic |
|
Date: |
Mon, 27 Jan 2020 11:39:56 +0100 |
On 1/27/20 10:48 AM, Michael Rolnik wrote:
> Not used. it's there just for clarity. to follow the pattern like PC
>
> AVR_FEATURE_1_BYTE_PC,
> AVR_FEATURE_2_BYTE_PC,
> AVR_FEATURE_3_BYTE_PC,
>
> AVR_FEATURE_1_BYTE_SP,
> AVR_FEATURE_2_BYTE_SP,
>
> To show that there is not 3 byte SP or so.
>
> Should I remove it?
Just asking, I get confused doing the review. I ratter prefer not to
have dead code, but is your call.
--joa
- [PATCH rc2 02/25] target/avr: Add instruction helpers, (continued)
Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic, Joaquin de Andres, 2020/01/27
[PATCH rc2 07/25] target/avr: Add instruction translation - Bit and Bit-test Instructions, Philippe Mathieu-Daudé, 2020/01/23
[PATCH rc2 04/25] target/avr: Add instruction translation - Arithmetic and Logic Instructions, Philippe Mathieu-Daudé, 2020/01/23
[PATCH rc2 08/25] target/avr: Add instruction translation - MCU Control Instructions, Philippe Mathieu-Daudé, 2020/01/23
[PATCH rc2 09/25] target/avr: Add instruction translation - CPU main translation function, Philippe Mathieu-Daudé, 2020/01/23
[PATCH rc2 10/25] target/avr: Add instruction disassembly function, Philippe Mathieu-Daudé, 2020/01/23
[PATCH rc2 06/25] target/avr: Add instruction translation - Data Transfer Instructions, Philippe Mathieu-Daudé, 2020/01/23
[PATCH rc2 11/25] hw/char: Add limited support for Atmel USART peripheral, Philippe Mathieu-Daudé, 2020/01/23