Re: [PATCH] RISC-V: Add a missing "," in riscv_excp_names

[Palmer Dabbelt]

On Thu, 05 Mar 2020 09:20:31 PST (-0800), address@hidden wrote:
> Cc'ing qemu-trivial@ in case there is a pending PR in  progress, it
> might get merged quicker.
>
> On Thu, Mar 5, 2020 at 6:19 PM Philippe Mathieu-Daudé <address@hidden> wrote:
> > On 3/5/20 5:48 PM, Palmer Dabbelt wrote:
> > > THis would almost certainly cause the exception names to be reported
> > > incorrectly.  Covarity found the issue (CID 1420223).  As per Peter's
> >
> > "This", "Coverity" typos.
> >
> > Fixes: ab67a1d07a4
> > Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Thanks.  I guess I'll just send the PR, as there's really no reason to block
this on the other RISC-V stuff.  It'll just be a single patch PR, so if the
patch goes in some other way then it should be easy to drop.  I usually don't
like rushing these sorts of things, but this one seems pretty safe.

> > > suggestion, I've also added a comma at the end of the list to avoid the issue
> > > reappearing in the future.
> > >
> > > Signed-off-by: Palmer Dabbelt <address@hidden>
> > > ---
> > >   target/riscv/cpu.c | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> > > index c47d10b739..c0b7023100 100644
> > > --- a/target/riscv/cpu.c
> > > +++ b/target/riscv/cpu.c
> > > @@ -66,7 +66,7 @@ const char * const riscv_excp_names[] = {
> > >       "exec_page_fault",
> > >       "load_page_fault",
> > >       "reserved",
> > > -    "store_page_fault"
> > > +    "store_page_fault",
> > >       "reserved",
> > >       "reserved",
> > >       "reserved",
> > > @@ -74,7 +74,7 @@ const char * const riscv_excp_names[] = {
> > >       "guest_exec_page_fault",
> > >       "guest_load_page_fault",
> > >       "reserved",
> > > -    "guest_store_page_fault"
> > > +    "guest_store_page_fault",
> > >   };
> > >
> > >   const char * const riscv_intr_names[] = {
> > >