Re: [PATCH v2 10/10] hw/semihosting: Make the feature depend of TCG, and allow to disable it

[Philippe Mathieu-Daudé]

On 5/19/20 11:44 PM, Richard Henderson wrote:
> On 5/15/20 10:08 AM, Philippe Mathieu-Daudé wrote:
> > +++ b/hw/semihosting/Kconfig
> > @@ -1,3 +1,5 @@
> >   
> > +# default is 'n'
> >   config SEMIHOSTING
> > -       bool
> > +    bool
> > +    depends on TCG
> > diff --git a/target/arm/Kconfig b/target/arm/Kconfig
> > new file mode 100644
> > index 0000000000..3224cac4ad
> > --- /dev/null
> > +++ b/target/arm/Kconfig
> > @@ -0,0 +1,2 @@
> > +config SEMIHOSTING
> > +    default y if TCG
>
> Do you really have to duplicate the TCG condition?

How so? The semihosting default table is:

      TCG KVM XEN
      y n y n y n
TCG y - - y y y y
    n   - n n n n
KVM y     - - n n
    n         n n
XEN y         - -
    n           -

So checking for TCG is the simpler way.

Maybe I'm not understanding well your question.

The logic is if TCG is selected, SEMIHOSTING is too.