[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] hw/char/serial: remove duplicate .class_init in serial_m

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 1/2] hw/char/serial: remove duplicate .class_init in serial_mm_info
Date: Fri, 9 Oct 2020 15:16:13 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 10/9/20 1:38 PM, Laurent Vivier wrote:
.class_init is already set to serial_mm_class_init.

Remove the duplicate entry.

Fixes: 17fd1a6490b1 ("serial-mm: add "regshift" property")
Cc: marcandre.lureau@redhat.com

I was going to send exactly the same one tomorrow =)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
  hw/char/serial.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/hw/char/serial.c b/hw/char/serial.c
index 4386adabd466..97f71879ff2a 100644
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -1120,7 +1120,6 @@ static const TypeInfo serial_mm_info = {
      .class_init = serial_mm_class_init,
      .instance_init = serial_mm_instance_init,
      .instance_size = sizeof(SerialMM),
-    .class_init = serial_mm_class_init,
static void serial_register_types(void)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]