[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/riscv: Fix implementation of HLVX.WU instruction

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] target/riscv: Fix implementation of HLVX.WU instruction
Date: Tue, 13 Oct 2020 21:42:21 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 10/13/20 7:22 PM, Georg Kotheimer wrote:
The HLVX.WU instruction is supposed to read a machine word,
but prior to this change it read a byte instead.

Fixes: 8c5362acb57 ("target/riscv: Allow generating hlv/hlvx/hsv instructions")
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Signed-off-by: Georg Kotheimer <georg.kotheimer@kernkonzept.com>
  target/riscv/op_helper.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c
index 9b9ada45a9..3b7bd6ee88 100644
--- a/target/riscv/op_helper.c
+++ b/target/riscv/op_helper.c
@@ -334,12 +334,12 @@ target_ulong helper_hyp_x_load(CPURISCVState *env, 
target_ulong address,
          riscv_cpu_set_two_stage_lookup(env, true);
switch (memop) {
-        case MO_TEUL:
-            pte = cpu_ldub_data_ra(env, address, GETPC());
-            break;
          case MO_TEUW:
              pte = cpu_lduw_data_ra(env, address, GETPC());
+        case MO_TEUL:
+            pte = cpu_ldl_data_ra(env, address, GETPC());
+            break;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]