Re: [PATCH v2 3/4] hw/riscv: Add a riscv_is_32_bit() function

[Palmer Dabbelt]

On Tue, 13 Oct 2020 17:17:30 PDT (-0700), Alistair Francis wrote:
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>  include/hw/riscv/boot.h | 2 ++
>  hw/riscv/boot.c         | 9 +++++++++
>  2 files changed, 11 insertions(+)
>
> diff --git a/include/hw/riscv/boot.h b/include/hw/riscv/boot.h
> index 0acbd8aa6e..2975ed1a31 100644
> --- a/include/hw/riscv/boot.h
> +++ b/include/hw/riscv/boot.h
> @@ -23,6 +23,8 @@
>  #include "exec/cpu-defs.h"
>  #include "hw/loader.h"
>
> +bool riscv_is_32_bit(MachineState *machine);
> +
>  target_ulong riscv_find_and_load_firmware(MachineState *machine,
>                                            const char *default_machine_firmware,
>                                            hwaddr firmware_load_addr,
> diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
> index fa699308a0..5dea644f47 100644
> --- a/hw/riscv/boot.c
> +++ b/hw/riscv/boot.c
> @@ -40,6 +40,15 @@
>  #define fw_dynamic_info_data(__val)     cpu_to_le64(__val)
>  #endif
>
> +bool riscv_is_32_bit(MachineState *machine)
> +{
> +    if (!strncmp(machine->cpu_type, "rv32", 4)) {
> +        return true;
> +    } else {
> +        return false;
> +    }
> +}
> +
>  target_ulong riscv_find_and_load_firmware(MachineState *machine,
>                                            const char *default_machine_firmware,
>                                            hwaddr firmware_load_addr,

Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>