[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 09/12] hw/pci-host/Kconfig: Add missing dependency MV64361

From: BALATON Zoltan
Subject: Re: [PATCH v2 09/12] hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259
Date: Sat, 15 May 2021 21:46:53 +0200 (CEST)

On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Looking at the MV64340 model source, there is a dependency on the
8259 interrupt controller:

 524         /* FIXME: Should this be sent via the PCI bus somehow? */
 525         if (s->gpp_int_level && (s->gpp_value & BIT(31))) {
 526             ret = pic_read_irq(isa_pic);
 527         }
 528         break;

Add it to Kconfig to avoid the following build failure:

 /usr/bin/ld: libcommon.fa.p/hw_pci-host_mv64361.c.o: in function 
 hw/pci-host/mv64361.c:526: undefined reference to `isa_pic'
 /usr/bin/ld: hw/pci-host/mv64361.c:526: undefined reference to `pic_read_irq'

Fixes: dcdf98a9015 ("hw/pci-host: Add emulation of Marvell MV64361 PPC system 
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>

Correct, this is a dependency that I've missed, although pegasos2 probably has it already and nothing else is using this chip but it's more correct to list it explicitely.

hw/pci-host/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig
index 79c20bf28bb..9dc0d761815 100644
--- a/hw/pci-host/Kconfig
+++ b/hw/pci-host/Kconfig
@@ -76,3 +76,4 @@ config SH_PCI
config MV64361
    select PCI
+    select I8259

reply via email to

[Prev in Thread] Current Thread [Next in Thread]