[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 02/12] hw/ide/Kconfig: Add missing dependency PCI -> IDE_Q

From: John Snow
Subject: Re: [PATCH v2 02/12] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV
Date: Tue, 18 May 2021 15:09:44 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 5/15/21 1:37 PM, Philippe Mathieu-Daudé wrote:
The pci_ide_create_devs() function is declared i hw/ide/qdev.c:

  $ git grep ide_create_drive
  hw/ide/pci.c:491:            ide_create_drive(d->bus + bus[i], unit[i], 
  hw/ide/qdev.c:127:IDEDevice *ide_create_drive(IDEBus *bus, int unit, 
DriveInfo *drive)
  include/hw/ide/internal.h:653:IDEDevice *ide_create_drive(IDEBus *bus, int 
unit, DriveInfo *drive);

Fix the correct symbol dependency to avoid build failure when
deselecting some machines:

   /usr/bin/ld: libcommon.fa.p/hw_ide_pci.c.o: in function 
   hw/ide/pci.c:491: undefined reference to `ide_create_drive'

Fixes: 8f01b41e109 ("ide: express dependencies with Kconfig")
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Acked-by: John Snow <jsnow@redhat.com>

  hw/ide/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig
index 8e2c8934549..dd85fa3619f 100644
--- a/hw/ide/Kconfig
+++ b/hw/ide/Kconfig
@@ -8,7 +8,7 @@ config IDE_QDEV
  config IDE_PCI
      depends on PCI
-    select IDE_CORE
+    select IDE_QDEV
config IDE_ISA

reply via email to

[Prev in Thread] Current Thread [Next in Thread]