[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/2] numa: Require distance map when empty node exists

From: Gavin Shan
Subject: Re: [PATCH v3 1/2] numa: Require distance map when empty node exists
Date: Fri, 15 Oct 2021 21:51:07 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0

Hi Drew,

On 10/15/21 7:33 PM, Andrew Jones wrote:
On Fri, Oct 15, 2021 at 07:22:05PM +1100, Gavin Shan wrote:
It's possible that the empty NUMA nodes aren't referred by any CPUs,
as the following command line indicate. In this case, the empty NUMA
node IDs aren't existing in device-tree CPU nodes. So we still need
the distance-map.

Ah, indeed.

However, I would like to drop this (PATCH[01/02]) in v4. The memory
hotplug through device-tree on ARM64 isn't existing. We might have
alternative ways to present the empty NUMA nodes when it's supported,
or we needn't it for ever because ACPI is enough to support the
memory hotplug.

Agreed. Please update the commit message of 2/2 for v4 and also add
a comment above the new code with the rationale for dropping those
memory nodes.

v4 was posted for review. Your r-b tag was dropped as the additional
comments are added. Please take a look on v4 and sorry for having
taken so much time from you :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]