[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 08/12] target/riscv: Handle KVM_EXIT_RISCV_SBI exit
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v1 08/12] target/riscv: Handle KVM_EXIT_RISCV_SBI exit |
|
Date: |
Sat, 20 Nov 2021 13:24:56 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
Hi,
On 11/20/21 08:46, Yifei Jiang wrote:
> Use char-fe to handle console sbi call, which implement early
> console io while apply 'earlycon=sbi' into kernel parameters.
>
> Signed-off-by: Yifei Jiang <jiangyifei@huawei.com>
> Signed-off-by: Mingwang Li <limingwang@huawei.com>
> ---
> target/riscv/kvm.c | 42 ++++++++++++++++-
> target/riscv/sbi_ecall_interface.h | 72 ++++++++++++++++++++++++++++++
> 2 files changed, 113 insertions(+), 1 deletion(-)
> create mode 100644 target/riscv/sbi_ecall_interface.h
>
> diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c
> index 8da2648d1a..6d419ba02e 100644
> --- a/target/riscv/kvm.c
> +++ b/target/riscv/kvm.c
> @@ -38,6 +38,8 @@
> #include "qemu/log.h"
> #include "hw/loader.h"
> #include "kvm_riscv.h"
> +#include "sbi_ecall_interface.h"
> +#include "chardev/char-fe.h"
>
> static uint64_t kvm_riscv_reg_id(CPURISCVState *env, uint64_t type, uint64_t
> idx)
> {
> @@ -440,9 +442,47 @@ bool kvm_arch_stop_on_emulation_error(CPUState *cs)
> return true;
> }
>
> +static int kvm_riscv_handle_sbi(struct kvm_run *run)
> +{
> + int ret = 0;
> + unsigned char ch;
> + switch (run->riscv_sbi.extension_id) {
> + case SBI_EXT_0_1_CONSOLE_PUTCHAR:
> + ch = run->riscv_sbi.args[0];
> + qemu_chr_fe_write(serial_hd(0)->be, &ch, sizeof(ch));
> + break;
> + case SBI_EXT_0_1_CONSOLE_GETCHAR:
> + ret = qemu_chr_fe_read_all(serial_hd(0)->be, &ch, sizeof(ch));
> + if (ret == sizeof(ch)) {
> + run->riscv_sbi.args[0] = ch;
> + } else {
> + run->riscv_sbi.args[0] = -1;
> + }
> + break;
Shouldn't this code use the Semihosting Console API from
"semihosting/console.h" instead?
- [PATCH v1 00/12] Add riscv kvm accel support, Yifei Jiang, 2021/11/20
- [PATCH v1 03/12] target/riscv: Implement function kvm_arch_init_vcpu, Yifei Jiang, 2021/11/20
- [PATCH v1 01/12] update-linux-headers: Add asm-riscv/kvm.h, Yifei Jiang, 2021/11/20
- [PATCH v1 02/12] target/riscv: Add target/riscv/kvm.c to place the public kvm interface, Yifei Jiang, 2021/11/20
- [PATCH v1 06/12] target/riscv: Support start kernel directly by KVM, Yifei Jiang, 2021/11/20
- [PATCH v1 04/12] target/riscv: Implement kvm_arch_get_registers, Yifei Jiang, 2021/11/20
- [PATCH v1 05/12] target/riscv: Implement kvm_arch_put_registers, Yifei Jiang, 2021/11/20
- [PATCH v1 08/12] target/riscv: Handle KVM_EXIT_RISCV_SBI exit, Yifei Jiang, 2021/11/20
- Re: [PATCH v1 08/12] target/riscv: Handle KVM_EXIT_RISCV_SBI exit,
Philippe Mathieu-Daudé <=
- [PATCH v1 07/12] target/riscv: Support setting external interrupt by KVM, Yifei Jiang, 2021/11/20
- [PATCH v1 09/12] target/riscv: Add host cpu type, Yifei Jiang, 2021/11/20
- [PATCH v1 10/12] target/riscv: Add kvm_riscv_get/put_regs_timer, Yifei Jiang, 2021/11/20
- [PATCH v1 11/12] target/riscv: Implement virtual time adjusting with vm state changing, Yifei Jiang, 2021/11/20
- [PATCH v1 12/12] target/riscv: Support virtual time context synchronization, Yifei Jiang, 2021/11/20