qemu-riscv
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 00/18] Adding partial support for 128-bit riscv target


From: Frédéric Pétrot
Subject: Re: [PATCH v7 00/18] Adding partial support for 128-bit riscv target
Date: Thu, 6 Jan 2022 16:35:42 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1

On 06/01/2022 09:33, Alistair Francis wrote:
On Tue, Dec 14, 2021 at 2:39 AM Frédéric Pétrot
<frederic.petrot@univ-grenoble-alpes.fr> wrote:

This series of patches provides partial 128-bit support for the riscv
target architecture, namely RVI and RVM, with minimal csr support.

Thanks again for the reviews and advices.

I think this is all reviewed now. I was getting an error when trying
to apply it though, do you mind rebasing on
https://github.com/alistair23/qemu/tree/riscv-to-apply.next ?

  Thanks Alistair,
  I will do that, sure.
  Frédéric

Alistair


v7:
- code motion following reviews
- correction of a bug preventing riscv{32,64}-linux-user to compile
- sync with master
- Note that 'make check' fails for 5 qemu-iotests cases, namely
   040, 041, 127, 256, and 267, but they also fail with
   qemu-system-riscv{32,64} from current master

v6:
- support for '-cpu rv128' in qemu-system-riscv64 to handle 128-bit
   executables (no more qemu-system-riscv128)
- remove useless (and buggy) big-endian support in lq/sq

v5:
- split the memop define renaming and addition in two patches
- 128-bit div/rem operations using host-utils functions
- removed useless rv128 tests at various places
- refactoring the slt/bxx part so as to share the comparison part
- refactoring the 128-bit csr handling to share code more largely
   Also forwarding writes to the 64-bit version when not 128-bit version
   exists, as a vast majority of the csrs does not use the upper 64-bits

v4:
- safer and cleaner access to the gpr upper part
- locals for load/store/div/rem helpers
- cleans out the 128-bit div/rem code
- corrects numerous bugs and performs optimizations on shifts and mults
- withdraws the change in page size and the vm schemes we introduced

v3:
- v2 refactored following Richard's xl patch changes

v2:
- load and store making use of new memop.h sizes
- use of the existing Int128 computations in helpers, and addition of
   a few more operations there, in particular division and remainder
- refactoring of the calls to the code generation helpers
- split of the patch in smaller pieces

v1:
- introducing support for rv128 for basic integer and M extension insns

Frédéric Pétrot (18):
   exec/memop: Adding signedness to quad definitions
   exec/memop: Adding signed quad and octo defines
   qemu/int128: addition of div/rem 128-bit operations
   target/riscv: additional macros to check instruction support
   target/riscv: separation of bitwise logic and arithmetic helpers
   target/riscv: array for the 64 upper bits of 128-bit registers
   target/riscv: setup everything for rv64 to support rv128 execution
   target/riscv: moving some insns close to similar insns
   target/riscv: accessors to registers upper part and 128-bit load/store
   target/riscv: support for 128-bit bitwise instructions
   target/riscv: support for 128-bit U-type instructions
   target/riscv: support for 128-bit shift instructions
   target/riscv: support for 128-bit arithmetic instructions
   target/riscv: support for 128-bit M extension
   target/riscv: adding high part of some csrs
   target/riscv: helper functions to wrap calls to 128-bit csr insns
   target/riscv: modification of the trans_csrxx for 128-bit support
   target/riscv: actual functions to realize crs 128-bit insns

  include/disas/dis-asm.h                    |   1 +
  include/exec/memop.h                       |  15 +-
  include/qemu/int128.h                      |  27 +
  include/tcg/tcg-op.h                       |   4 +-
  target/arm/translate-a32.h                 |   4 +-
  target/riscv/cpu.h                         |  22 +
  target/riscv/cpu_bits.h                    |   3 +
  target/riscv/helper.h                      |   9 +
  target/riscv/insn16.decode                 |  27 +-
  target/riscv/insn32.decode                 |  25 +
  accel/tcg/cputlb.c                         |  30 +-
  accel/tcg/user-exec.c                      |   8 +-
  disas/riscv.c                              |   5 +
  target/alpha/translate.c                   |  32 +-
  target/arm/helper-a64.c                    |   8 +-
  target/arm/translate-a64.c                 |   8 +-
  target/arm/translate-neon.c                |   6 +-
  target/arm/translate-sve.c                 |  10 +-
  target/arm/translate-vfp.c                 |   8 +-
  target/arm/translate.c                     |   2 +-
  target/cris/translate.c                    |   2 +-
  target/hppa/translate.c                    |   4 +-
  target/i386/tcg/mem_helper.c               |   2 +-
  target/i386/tcg/translate.c                |  36 +-
  target/m68k/op_helper.c                    |   2 +-
  target/mips/tcg/translate.c                |  58 +-
  target/mips/tcg/tx79_translate.c           |   8 +-
  target/ppc/translate.c                     |  32 +-
  target/riscv/cpu.c                         |  29 +
  target/riscv/csr.c                         | 194 +++++-
  target/riscv/gdbstub.c                     |   5 +
  target/riscv/m128_helper.c                 | 109 +++
  target/riscv/machine.c                     |  22 +
  target/riscv/op_helper.c                   |  44 ++
  target/riscv/translate.c                   | 252 ++++++-
  target/s390x/tcg/mem_helper.c              |   8 +-
  target/s390x/tcg/translate.c               |   8 +-
  target/sh4/translate.c                     |  12 +-
  target/sparc/translate.c                   |  36 +-
  target/tricore/translate.c                 |   4 +-
  target/xtensa/translate.c                  |   4 +-
  tcg/tcg.c                                  |   4 +-
  tcg/tci.c                                  |  16 +-
  util/int128.c                              | 147 +++++
  accel/tcg/ldst_common.c.inc                |   8 +-
  target/mips/tcg/micromips_translate.c.inc  |  10 +-
  target/ppc/translate/fixedpoint-impl.c.inc |  22 +-
  target/ppc/translate/fp-impl.c.inc         |   4 +-
  target/ppc/translate/vsx-impl.c.inc        |  42 +-
  target/riscv/insn_trans/trans_rva.c.inc    |  22 +-
  target/riscv/insn_trans/trans_rvb.c.inc    |  48 +-
  target/riscv/insn_trans/trans_rvd.c.inc    |   4 +-
  target/riscv/insn_trans/trans_rvh.c.inc    |   4 +-
  target/riscv/insn_trans/trans_rvi.c.inc    | 730 ++++++++++++++++++---
  target/riscv/insn_trans/trans_rvm.c.inc    | 192 +++++-
  target/s390x/tcg/translate_vx.c.inc        |  18 +-
  tcg/aarch64/tcg-target.c.inc               |   2 +-
  tcg/arm/tcg-target.c.inc                   |  10 +-
  tcg/i386/tcg-target.c.inc                  |  12 +-
  tcg/mips/tcg-target.c.inc                  |  12 +-
  tcg/ppc/tcg-target.c.inc                   |  16 +-
  tcg/riscv/tcg-target.c.inc                 |   6 +-
  tcg/s390x/tcg-target.c.inc                 |  18 +-
  tcg/sparc/tcg-target.c.inc                 |  16 +-
  target/riscv/meson.build                   |   1 +
  target/s390x/tcg/insn-data.def             |  28 +-
  util/meson.build                           |   1 +
  67 files changed, 2006 insertions(+), 512 deletions(-)
  create mode 100644 target/riscv/m128_helper.c
  create mode 100644 util/int128.c

--
2.34.1



--
+---------------------------------------------------------------------------+
| Frédéric Pétrot, Pr. Grenoble INP-Ensimag/TIMA,   Ensimag deputy director |
| Mob/Pho: +33 6 74 57 99 65/+33 4 76 57 48 70      Ad augusta  per angusta |
| http://tima.univ-grenoble-alpes.fr frederic.petrot@univ-grenoble-alpes.fr |
+---------------------------------------------------------------------------+



reply via email to

[Prev in Thread] Current Thread [Next in Thread]