[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 05/12] target/riscv: Implement kvm_arch_put_registers
From: |
Alistair Francis |
Subject: |
Re: [PATCH v4 05/12] target/riscv: Implement kvm_arch_put_registers |
Date: |
Tue, 11 Jan 2022 09:06:46 +1000 |
On Mon, Jan 10, 2022 at 11:57 AM Yifei Jiang via <qemu-devel@nongnu.org> wrote:
>
> Put GPR CSR and FP registers to kvm by KVM_SET_ONE_REG ioctl
>
> Signed-off-by: Yifei Jiang <jiangyifei@huawei.com>
> Signed-off-by: Mingwang Li <limingwang@huawei.com>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> Reviewed-by: Anup Patel <anup.patel@wdc.com>
> ---
> target/riscv/kvm.c | 104 ++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 103 insertions(+), 1 deletion(-)
>
> diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c
> index 6d4df0ef6d..e695b91dc7 100644
> --- a/target/riscv/kvm.c
> +++ b/target/riscv/kvm.c
> @@ -73,6 +73,14 @@ static uint64_t kvm_riscv_reg_id(CPURISCVState *env,
> uint64_t type, uint64_t idx
> } \
> } while(0)
>
> +#define KVM_RISCV_SET_CSR(cs, env, csr, reg) \
> + do { \
> + int ret = kvm_set_one_reg(cs, RISCV_CSR_REG(env, csr), ®); \
> + if (ret) { \
> + return ret; \
> + } \
> + } while(0)
This fails checkpatch. I know there is lots of QEMU code like this,
but it probably should be `while (0)` to keep checkpatch happy.
Please run checkpatch on all the patches.
Alistair
- [PATCH v4 07/12] target/riscv: Support setting external interrupt by KVM, (continued)
- [PATCH v4 07/12] target/riscv: Support setting external interrupt by KVM, Yifei Jiang, 2022/01/09
- [PATCH v4 04/12] target/riscv: Implement kvm_arch_get_registers, Yifei Jiang, 2022/01/09
- [PATCH v4 08/12] target/riscv: Handle KVM_EXIT_RISCV_SBI exit, Yifei Jiang, 2022/01/09
- [PATCH v4 10/12] target/riscv: Add kvm_riscv_get/put_regs_timer, Yifei Jiang, 2022/01/09
- [PATCH v4 12/12] target/riscv: Support virtual time context synchronization, Yifei Jiang, 2022/01/09
- [PATCH v4 11/12] target/riscv: Implement virtual time adjusting with vm state changing, Yifei Jiang, 2022/01/09
- [PATCH v4 09/12] target/riscv: Add host cpu type, Yifei Jiang, 2022/01/09
- [PATCH v4 05/12] target/riscv: Implement kvm_arch_put_registers, Yifei Jiang, 2022/01/09
- Re: [PATCH v4 05/12] target/riscv: Implement kvm_arch_put_registers,
Alistair Francis <=