qemu-riscv
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC 2/5] target/riscv: Introduce privilege version field in the CSR


From: Atish Kumar Patra
Subject: Re: [RFC 2/5] target/riscv: Introduce privilege version field in the CSR ops.
Date: Fri, 28 Jan 2022 16:52:32 -0800



On Sun, Jan 23, 2022 at 11:56 PM Richard Henderson <richard.henderson@linaro.org> wrote:
On 1/21/22 7:07 AM, Atish Patra wrote:
> +    [CSR_VSTART]   = { "vstart",   vs,     read_vstart,  write_vstart, NULL,
> +                                           NULL, NULL, PRIV_VERSION_1_12_0 },

I think adding all of these NULLs are hard to read.
Better to just add

     .min_priv_ver = PRIV_VERSION_1_12_0

to the existing entry.


Yeah. That's better. Fixed it.
 

r~

reply via email to

[Prev in Thread] Current Thread [Next in Thread]