[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 4/5] target/riscv: add support for svinval extension
From: |
Alistair Francis |
Subject: |
Re: [PATCH v8 4/5] target/riscv: add support for svinval extension |
Date: |
Thu, 3 Feb 2022 11:04:36 +1000 |
On Wed, Feb 2, 2022 at 2:46 AM Weiwei Li <liweiwei@iscas.ac.cn> wrote:
>
> - sinval.vma, hinval.vvma and hinval.gvma do the same as sfence.vma,
> hfence.vvma and hfence.gvma except extension check
> - do nothing other than extension check for sfence.w.inval and sfence.inval.ir
>
> Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn>
> Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn>
> Reviewed-by: Anup Patel <anup@brainfault.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/cpu.c | 1 +
> target/riscv/cpu.h | 1 +
> target/riscv/insn32.decode | 7 ++
> target/riscv/insn_trans/trans_svinval.c.inc | 75 +++++++++++++++++++++
> target/riscv/translate.c | 1 +
> 5 files changed, 85 insertions(+)
> create mode 100644 target/riscv/insn_trans/trans_svinval.c.inc
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index cfaccdfc72..4442c4b81d 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -729,6 +729,7 @@ static Property riscv_cpu_properties[] = {
> DEFINE_PROP_UINT16("vlen", RISCVCPU, cfg.vlen, 128),
> DEFINE_PROP_UINT16("elen", RISCVCPU, cfg.elen, 64),
>
> + DEFINE_PROP_BOOL("svinval", RISCVCPU, cfg.ext_svinval, false),
> DEFINE_PROP_BOOL("svnapot", RISCVCPU, cfg.ext_svnapot, false),
>
> DEFINE_PROP_BOOL("zba", RISCVCPU, cfg.ext_zba, true),
> diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
> index 8e7c33c9cb..5622478eb5 100644
> --- a/target/riscv/cpu.h
> +++ b/target/riscv/cpu.h
> @@ -324,6 +324,7 @@ struct RISCVCPUConfig {
> bool ext_counters;
> bool ext_ifencei;
> bool ext_icsr;
> + bool ext_svinval;
> bool ext_svnapot;
> bool ext_svpbmt;
> bool ext_zfh;
> diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode
> index 5bbedc254c..1d3ff1efe1 100644
> --- a/target/riscv/insn32.decode
> +++ b/target/riscv/insn32.decode
> @@ -809,3 +809,10 @@ fcvt_l_h 1100010 00010 ..... ... ..... 1010011 @r2_rm
> fcvt_lu_h 1100010 00011 ..... ... ..... 1010011 @r2_rm
> fcvt_h_l 1101010 00010 ..... ... ..... 1010011 @r2_rm
> fcvt_h_lu 1101010 00011 ..... ... ..... 1010011 @r2_rm
> +
> +# *** Svinval Standard Extension ***
> +sinval_vma 0001011 ..... ..... 000 00000 1110011 @sfence_vma
> +sfence_w_inval 0001100 00000 00000 000 00000 1110011
> +sfence_inval_ir 0001100 00001 00000 000 00000 1110011
> +hinval_vvma 0010011 ..... ..... 000 00000 1110011 @hfence_vvma
> +hinval_gvma 0110011 ..... ..... 000 00000 1110011 @hfence_gvma
> diff --git a/target/riscv/insn_trans/trans_svinval.c.inc
> b/target/riscv/insn_trans/trans_svinval.c.inc
> new file mode 100644
> index 0000000000..2682bd969f
> --- /dev/null
> +++ b/target/riscv/insn_trans/trans_svinval.c.inc
> @@ -0,0 +1,75 @@
> +/*
> + * RISC-V translation routines for the Svinval Standard Instruction Set.
> + *
> + * Copyright (c) 2020-2022 PLCT lab
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2 or later, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> with
> + * this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#define REQUIRE_SVINVAL(ctx) do { \
> + if (!ctx->cfg_ptr->ext_svinval) { \
> + return false; \
> + } \
> +} while (0)
> +
> +static bool trans_sinval_vma(DisasContext *ctx, arg_sinval_vma *a)
> +{
> + REQUIRE_SVINVAL(ctx);
> + /* Do the same as sfence.vma currently */
> + REQUIRE_EXT(ctx, RVS);
> +#ifndef CONFIG_USER_ONLY
> + gen_helper_tlb_flush(cpu_env);
> + return true;
> +#endif
> + return false;
> +}
> +
> +static bool trans_sfence_w_inval(DisasContext *ctx, arg_sfence_w_inval *a)
> +{
> + REQUIRE_SVINVAL(ctx);
> + REQUIRE_EXT(ctx, RVS);
> + /* Do nothing currently */
> + return true;
> +}
> +
> +static bool trans_sfence_inval_ir(DisasContext *ctx, arg_sfence_inval_ir *a)
> +{
> + REQUIRE_SVINVAL(ctx);
> + REQUIRE_EXT(ctx, RVS);
> + /* Do nothing currently */
> + return true;
> +}
> +
> +static bool trans_hinval_vvma(DisasContext *ctx, arg_hinval_vvma *a)
> +{
> + REQUIRE_SVINVAL(ctx);
> + /* Do the same as hfence.vvma currently */
> + REQUIRE_EXT(ctx, RVH);
> +#ifndef CONFIG_USER_ONLY
> + gen_helper_hyp_tlb_flush(cpu_env);
> + return true;
> +#endif
> + return false;
> +}
> +
> +static bool trans_hinval_gvma(DisasContext *ctx, arg_hinval_gvma *a)
> +{
> + REQUIRE_SVINVAL(ctx);
> + /* Do the same as hfence.gvma currently */
> + REQUIRE_EXT(ctx, RVH);
> +#ifndef CONFIG_USER_ONLY
> + gen_helper_hyp_gvma_tlb_flush(cpu_env);
> + return true;
> +#endif
> + return false;
> +}
> diff --git a/target/riscv/translate.c b/target/riscv/translate.c
> index eaf5a72c81..84dbfa6340 100644
> --- a/target/riscv/translate.c
> +++ b/target/riscv/translate.c
> @@ -862,6 +862,7 @@ static uint32_t opcode_at(DisasContextBase *dcbase,
> target_ulong pc)
> #include "insn_trans/trans_rvb.c.inc"
> #include "insn_trans/trans_rvzfh.c.inc"
> #include "insn_trans/trans_privileged.c.inc"
> +#include "insn_trans/trans_svinval.c.inc"
> #include "insn_trans/trans_xventanacondops.c.inc"
>
> /* Include the auto-generated decoder for 16 bit insn */
> --
> 2.17.1
>
>
- [PATCH v8 0/5] support subsets of virtual memory extension, Weiwei Li, 2022/02/01
- [PATCH v8 2/5] target/riscv: add PTE_A/PTE_D/PTE_U bits check for inner PTE, Weiwei Li, 2022/02/01
- [PATCH v8 5/5] target/riscv: add support for svpbmt extension, Weiwei Li, 2022/02/01
- [PATCH v8 1/5] target/riscv: Ignore reserved bits in PTE for RV64, Weiwei Li, 2022/02/01
- [PATCH v8 3/5] target/riscv: add support for svnapot extension, Weiwei Li, 2022/02/01
- [PATCH v8 4/5] target/riscv: add support for svinval extension, Weiwei Li, 2022/02/01
- Re: [PATCH v8 4/5] target/riscv: add support for svinval extension,
Alistair Francis <=