[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/6] hw/riscv: Add TPM support to the virt board
From: |
Edgar E. Iglesias |
Subject: |
Re: [PATCH v2 0/6] hw/riscv: Add TPM support to the virt board |
Date: |
Thu, 7 Apr 2022 15:30:59 +0200 |
On Thu, Apr 07, 2022 at 12:04:26PM +1000, Alistair Francis wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
>
> This series adds support for connecting TPM devices to the RISC-V virt
> board. This is similar to how it works for the ARM virt board.
>
> This was tested by first creating an emulated TPM device:
>
> swtpm socket --tpm2 -t -d --tpmstate dir=/tmp/tpm \
> --ctrl type=unixio,path=swtpm-sock
>
> Then launching QEMU with:
>
> -chardev socket,id=chrtpm,path=swtpm-sock \
> -tpmdev emulator,id=tpm0,chardev=chrtpm \
> -device tpm-tis-device,tpmdev=tpm0
>
> The TPM device can be seen in the memory tree and the generated device
> tree.
Hi Alistair!
You've got a typo in the subject of patch 4/6 "generating".
On the series:
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
Cheers,
Edgar
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/942
>
> Alistair Francis (6):
> hw/riscv: virt: Add a machine done notifier
> hw/core: Move the ARM sysbus-fdt to core
> hw/riscv: virt: Create a platform bus
> hw/riscv: virt: Add support for generateing platform FDT entries
> hw/riscv: virt: Add device plug support
> hw/riscv: Enable TPM backends
>
> include/hw/{arm => core}/sysbus-fdt.h | 0
> include/hw/riscv/virt.h | 8 +-
> hw/arm/virt.c | 2 +-
> hw/arm/xlnx-versal-virt.c | 1 -
> hw/{arm => core}/sysbus-fdt.c | 2 +-
> hw/riscv/virt.c | 312 +++++++++++++++++---------
> hw/arm/meson.build | 1 -
> hw/core/meson.build | 1 +
> hw/riscv/Kconfig | 2 +
> 9 files changed, 221 insertions(+), 108 deletions(-)
> rename include/hw/{arm => core}/sysbus-fdt.h (100%)
> rename hw/{arm => core}/sysbus-fdt.c (99%)
>
> --
> 2.35.1
>
- [PATCH v2 0/6] hw/riscv: Add TPM support to the virt board, Alistair Francis, 2022/04/06
- [PATCH v2 1/6] hw/riscv: virt: Add a machine done notifier, Alistair Francis, 2022/04/06
- [PATCH v2 2/6] hw/core: Move the ARM sysbus-fdt to core, Alistair Francis, 2022/04/06
- [PATCH v2 3/6] hw/riscv: virt: Create a platform bus, Alistair Francis, 2022/04/06
- [PATCH v2 4/6] hw/riscv: virt: Add support for generateing platform FDT entries, Alistair Francis, 2022/04/06
- [PATCH v2 5/6] hw/riscv: virt: Add device plug support, Alistair Francis, 2022/04/06
- [PATCH v2 6/6] hw/riscv: Enable TPM backends, Alistair Francis, 2022/04/06
- Re: [PATCH v2 0/6] hw/riscv: Add TPM support to the virt board,
Edgar E. Iglesias <=