[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] target/riscv: disable zb* extensions by default

From: Weiwei Li
Subject: Re: [PATCH 2/2] target/riscv: disable zb* extensions by default
Date: Tue, 17 May 2022 09:34:04 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

在 2022/5/17 上午8:54, Alistair Francis 写道:
On Tue, May 17, 2022 at 10:33 AM Alistair Francis <alistair23@gmail.com> wrote:
On Mon, May 16, 2022 at 1:34 PM Weiwei Li <liweiwei@iscas.ac.cn> wrote:
  - enable zb* extensions by default will make cpu types(such as sifive-u34) 
implicitly support zb* extensions
Agh, this is a pain.

Can you enable these by default for the base machines then? That way
they will be enabled for the virt machine
Actually, come to think of it, we can probably just register the
riscv_cpu_properties for the base cpus. That way only those CPUs can
be configured by the user. Can you do that instead?


Yeah, This is OK. I'll do this later.


Weiwei Li


Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn>
Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn>
  target/riscv/cpu.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index b12f69c584..a3a17323e7 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -847,13 +847,13 @@ static Property riscv_cpu_properties[] = {
      DEFINE_PROP_BOOL("svnapot", RISCVCPU, cfg.ext_svnapot, false),
      DEFINE_PROP_BOOL("svpbmt", RISCVCPU, cfg.ext_svpbmt, false),

-    DEFINE_PROP_BOOL("zba", RISCVCPU, cfg.ext_zba, true),
-    DEFINE_PROP_BOOL("zbb", RISCVCPU, cfg.ext_zbb, true),
-    DEFINE_PROP_BOOL("zbc", RISCVCPU, cfg.ext_zbc, true),
+    DEFINE_PROP_BOOL("zba", RISCVCPU, cfg.ext_zba, false),
+    DEFINE_PROP_BOOL("zbb", RISCVCPU, cfg.ext_zbb, false),
+    DEFINE_PROP_BOOL("zbc", RISCVCPU, cfg.ext_zbc, false),
      DEFINE_PROP_BOOL("zbkb", RISCVCPU, cfg.ext_zbkb, false),
      DEFINE_PROP_BOOL("zbkc", RISCVCPU, cfg.ext_zbkc, false),
      DEFINE_PROP_BOOL("zbkx", RISCVCPU, cfg.ext_zbkx, false),
-    DEFINE_PROP_BOOL("zbs", RISCVCPU, cfg.ext_zbs, true),
+    DEFINE_PROP_BOOL("zbs", RISCVCPU, cfg.ext_zbs, false),
      DEFINE_PROP_BOOL("zk", RISCVCPU, cfg.ext_zk, false),
      DEFINE_PROP_BOOL("zkn", RISCVCPU, cfg.ext_zkn, false),
      DEFINE_PROP_BOOL("zknd", RISCVCPU, cfg.ext_zknd, false),

reply via email to

[Prev in Thread] Current Thread [Next in Thread]