[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/6] target/riscv: add check for supported privilege modes

From: Weiwei Li
Subject: Re: [PATCH v2 1/6] target/riscv: add check for supported privilege modes conbinations
Date: Mon, 18 Jul 2022 19:36:28 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

在 2022/7/18 下午5:02, Andrew Jones 写道:
On Tue, Jul 12, 2022 at 02:32:31PM +0800, Weiwei Li wrote:
- There are 3 suggested privilege modes conbinations listed in the spec:
No need for '-' here.


(Same typos in $SUBJECT, also please capitalize 'add' in $SUBJECT.)

When referencing the spec it's nice to point out the doc/version/section.

1) M, 2) M, U 3) M, S, U

Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn>
Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
  target/riscv/cpu.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index db2b8e4d30..36c1b26fb3 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -726,6 +726,12 @@ static void riscv_cpu_realize(DeviceState *dev, Error 
+ if (cpu->cfg.ext_s && !cpu->cfg.ext_u) {
+            error_setg(errp,
+                       "Setting S extension without U extension is illegal");
+            return;
+        }
          if (cpu->cfg.ext_f && !cpu->cfg.ext_icsr) {
              error_setg(errp, "F extension requires Zicsr");

Besides the commit message issues

Reviewed-by: Andrew Jones <ajones@ventanamicro.com>

Thanks for your comments.

I'll fix the issues in commit messages in the next version.


Weiwei Li

reply via email to

[Prev in Thread] Current Thread [Next in Thread]