[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/4] hw/riscv: virt: fix uart node name
From: |
Conor.Dooley |
Subject: |
Re: [PATCH v2 1/4] hw/riscv: virt: fix uart node name |
Date: |
Thu, 18 Aug 2022 06:29:10 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 |
On 17/08/2022 21:05, Conor Dooley wrote:
I didn't realise this one slipped out too when I messed up mailing
unrelated patches yesterday, this is identical to what I previously
submitted as a v2 - I ran send-email on a dirty directory...
I can re-submit this as v3 if it makes things easier?
Thanks,
Conor.
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> From: Conor Dooley <conor.dooley@microchip.com>
>
> "uart" is not a node name that complies with the dt-schema.
> Change the node name to "serial" to ix warnings seen during
> dt-validate on a dtbdump of the virt machine such as:
> /stuff/qemu/qemu.dtb: uart@10000000: $nodename:0: 'uart@10000000' does not
> match '^serial(@.*)?$'
> From schema:
> /stuff/linux/Documentation/devicetree/bindings/serial/8250.yaml
>
> Reported-by: Rob Herring <robh@kernel.org>
> Link:
> https://lore.kernel.org/linux-riscv/20220803170552.GA2250266-robh@kernel.org/
> Fixes: 04331d0b56 ("RISC-V VirtIO Machine")
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> hw/riscv/virt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
> index bc424dd2f5..6c61a406c4 100644
> --- a/hw/riscv/virt.c
> +++ b/hw/riscv/virt.c
> @@ -917,7 +917,7 @@ static void create_fdt_uart(RISCVVirtState *s, const
> MemMapEntry *memmap,
> char *name;
> MachineState *mc = MACHINE(s);
>
> - name = g_strdup_printf("/soc/uart@%lx", (long)memmap[VIRT_UART0].base);
> + name = g_strdup_printf("/soc/serial@%lx", (long)memmap[VIRT_UART0].base);
> qemu_fdt_add_subnode(mc->fdt, name);
> qemu_fdt_setprop_string(mc->fdt, name, "compatible", "ns16550a");
> qemu_fdt_setprop_cells(mc->fdt, name, "reg",
> --
> 2.37.1
>
- [PATCH 1/4] dt-bindings: timer: sifive, clint: add legacy riscv compatible, (continued)
- [PATCH 1/4] dt-bindings: timer: sifive, clint: add legacy riscv compatible, Conor Dooley, 2022/08/17
- [PATCH 2/4] dt-bindings: interrupt-controller: sifive, plic: add legacy riscv compatible, Conor Dooley, 2022/08/17
- [PATCH 3/4] dt-bindings: riscv: add new riscv, isa strings for emulators, Conor Dooley, 2022/08/17
- [NOT-A-PATCH 4/4] dt-bindings: riscv: isa string bonus content, Conor Dooley, 2022/08/17
- [PATCH v2 0/4] Fix dt-validate issues on qemu dtbdumps due to dt-bindings, Conor Dooley, 2022/08/17
- [PATCH v2 1/4] dt-bindings: timer: sifive, clint: add legacy riscv compatible, Conor Dooley, 2022/08/17
- [PATCH v2 1/4] hw/riscv: virt: fix uart node name, Conor Dooley, 2022/08/17
- Re: [PATCH v2 1/4] hw/riscv: virt: fix uart node name,
Conor.Dooley <=
- Re: [PATCH 0/4] Fix dt-validate issues on qemu dtbdumps due to dt-bindings, Conor Dooley, 2022/08/17