[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V4 1/3] hw/arm, loongarch: Move load_image_to_fw_cfg() to com
Sunil V L
Re: [PATCH V4 1/3] hw/arm, loongarch: Move load_image_to_fw_cfg() to common location
Thu, 22 Sep 2022 16:58:54 +0530
On Thu, Sep 15, 2022 at 08:56:01PM +0800, gaosong wrote:
> 在 2022/9/15 下午7:59, Sunil V L 写道:
> > Hi,
> > Could maintainers of hw/arm and hw/loongarch to take a look at this? I
> > have addressed Peter's earlier comment.
> > Thanks
> > Sunil
> > On Thu, Sep 08, 2022 at 11:17:52AM +0200, Alistair Francis wrote:
> > > On Tue, Sep 6, 2022 at 11:38 AM Sunil V L <email@example.com>
> > > wrote:
> > > > load_image_to_fw_cfg() is duplicated by both arm and loongarch. The same
> > > > function will be required by riscv too. So, it's time to refactor and
> > > > move this function to a common path.
> > > >
> > > > Signed-off-by: Sunil V L <firstname.lastname@example.org>
> > > > Reviewed-by: Andrew Jones <email@example.com>
> > > Reviewed-by: Alistair Francis <firstname.lastname@example.org>
> > >
> > > Alistair
> Reviewed-by: Song Gao <email@example.com>
> Song Gao
Thanks Song Gao.
Could you please provide RB or ACK if things are fine with this patch?
[PATCH V4 2/3] hw/riscv: virt: Move create_fw_cfg() prior to loading kernel, Sunil V L, 2022/09/06
[PATCH V4 3/3] hw/riscv: virt: Enable booting S-mode firmware from pflash, Sunil V L, 2022/09/06
Re: [PATCH V4 0/3] hw/riscv: virt: Enable booting S-mode firmware from pflash, Gerd Hoffmann, 2022/09/06