Re: [PATCH v2 16/21] gdbstub: specialise stub_can_reverse

[Philippe Mathieu-Daudé]

On 5/1/23 17:43, Alex Bennée wrote:
> Currently we only support replay for softmmu mode so it is a constant
> false for user-mode.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   gdbstub/internals.h |  1 +
>   gdbstub/gdbstub.c   | 13 ++-----------
>   gdbstub/softmmu.c   |  5 +++++
>   gdbstub/user.c      |  5 +++++
>   4 files changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/gdbstub/internals.h b/gdbstub/internals.h
> index a371373c1d..1def9dfc9c 100644
> --- a/gdbstub/internals.h
> +++ b/gdbstub/internals.h
> @@ -126,6 +126,7 @@ CPUState *gdb_first_attached_cpu(void);
>   void gdb_append_thread_id(CPUState *cpu, GString *buf);
>   int gdb_get_cpu_index(CPUState *cpu);
>   unsigned int gdb_get_max_cpus(void); /* both */
> +bool gdb_stub_can_reverse(void); /* softmmu, stub for user */
Maybe without the 'stub', gdb_can_reverse()?

Anyhow,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>