[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 3/5] riscv: Allow user to set the satp mode
From: |
Andrew Jones |
Subject: |
Re: [PATCH v6 3/5] riscv: Allow user to set the satp mode |
Date: |
Mon, 23 Jan 2023 11:29:12 +0100 |
On Mon, Jan 23, 2023 at 10:03:22AM +0100, Alexandre Ghiti wrote:
...
> +/* Sets the satp mode to the max supported */
> +static void set_satp_mode_default(RISCVCPU *cpu, bool is_32_bit)
> +{
nit: When passing in the cpu object pointer there's no need to also pass
is_32_bit, we can just use it from the pointer, cpu->env.misa_mxl == MXL_RV32
Thanks,
drew
- [PATCH v6 0/5] riscv: Allow user to set the satp mode, Alexandre Ghiti, 2023/01/23
- [PATCH v6 1/5] riscv: Pass Object to register_cpu_props instead of DeviceState, Alexandre Ghiti, 2023/01/23
- [PATCH v6 2/5] riscv: Change type of valid_vm_1_10_[32|64] to bool, Alexandre Ghiti, 2023/01/23
- [PATCH v6 3/5] riscv: Allow user to set the satp mode, Alexandre Ghiti, 2023/01/23
- [PATCH v6 4/5] riscv: Correctly set the device-tree entry 'mmu-type', Alexandre Ghiti, 2023/01/23
- [PATCH v6 5/5] riscv: Introduce satp mode hw capabilities, Alexandre Ghiti, 2023/01/23
- Re: [PATCH v6 5/5] riscv: Introduce satp mode hw capabilities, Alexandre Ghiti, 2023/01/24