[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 19/19] Drop duplicate #include
From: |
Juan Quintela |
Subject: |
Re: [PATCH v4 19/19] Drop duplicate #include |
Date: |
Mon, 30 Jan 2023 05:16:37 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> wrote:
> Tracked down with the help of scripts/clean-includes.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> index b9a37ef255..8b7d1af75d 100644
> --- a/migration/postcopy-ram.c
> +++ b/migration/postcopy-ram.c
> @@ -17,7 +17,6 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/rcu.h"
> #include "qemu/madvise.h"
> #include "exec/target_page.h"
> #include "migration.h"
> @@ -34,7 +33,6 @@
> #include "hw/boards.h"
> #include "exec/ramblock.h"
> #include "socket.h"
> -#include "qemu-file.h"
> #include "yank_functions.h"
> #include "tls.h"
Ouch
Reviewed-by: Juan Quintela <quintela@redhat.com>
I don't want to look into the logs. They *could* say that it was me the
one doing the mess.
- [PATCH v4 18/19] 9p: Drop superfluous include of linux/limits.h, (continued)
- [PATCH v4 13/19] riscv: Clean up includes, Markus Armbruster, 2023/01/19
- [PATCH v4 19/19] Drop duplicate #include, Markus Armbruster, 2023/01/19
- [PATCH v4 12/19] target/hexagon: Clean up includes, Markus Armbruster, 2023/01/19
- [PATCH v4 07/19] hw/input: Clean up includes, Markus Armbruster, 2023/01/19
- [PATCH v4 08/19] hw/tricore: Clean up includes, Markus Armbruster, 2023/01/19
- [PATCH v4 17/19] Don't include headers already included by qemu/osdep.h, Markus Armbruster, 2023/01/19
- [PATCH v4 16/19] Fix non-first inclusions of qemu/osdep.h, Markus Armbruster, 2023/01/19