[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 01/19] scripts/clean-includes: Fully skip / ignore files
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v4 01/19] scripts/clean-includes: Fully skip / ignore files |
Date: |
Mon, 30 Jan 2023 13:55:48 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Thu, Jan 19, 2023 at 07:59:41AM +0100, Markus Armbruster wrote:
>> When clean-includes claims to skip or ignore a file, only the part
>> that sanitizes use of qemu/osdep.h skips the file. The part that
>> looks for duplicate #include does not, and neither does committing to
>> Git.
>>
>> The latter can get unrelated stuff included in the commit, but only if
>> you run clean-includes in a dirty tree, which is unwise. Messed up
>> when we added skipping in commit fd3e39a40c "scripts/clean-includes:
>> Enhance to handle header files".
>>
>> The former can cause bogus reports for --check-dup-head. Added in
>> commit d66253e46a "scripts/clean-includes: added duplicate #include
>> check", duplicating the prior mistake.
>>
>> Fix the script to fully skip files.
>>
>> Fixes: fd3e39a40ca2ee26b09a5de3149af8b056b85233
>> Fixes: d66253e46ae2b9c36a9dd90b2b74c0dfa5804b22
>
> Isn't
> Fixes: %h (\"%s\")
>
> the accepted format for this?
It seems to be common these days. I'll adjust.
[PATCH v4 14/19] block: Clean up includes, Markus Armbruster, 2023/01/19
[PATCH v4 03/19] scripts/clean-includes: Skip symbolic links, Markus Armbruster, 2023/01/19