[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] target/riscv: set tval for triggered watchpoints
From: |
Bin Meng |
Subject: |
Re: [PATCH v2] target/riscv: set tval for triggered watchpoints |
Date: |
Wed, 1 Feb 2023 12:11:22 +0800 |
On Wed, Feb 1, 2023 at 1:35 AM Sergey Matyukevich <geomatsi@gmail.com> wrote:
>
> From: Sergey Matyukevich <sergey.matyukevich@syntacore.com>
>
> According to priviledged spec, if [sm]tval is written with a nonzero
typo: privileged
> value when a breakpoint exception occurs, then [sm]tval will contain
> the faulting virtual address. Set tval to hit address when breakpoint
> exception is triggered by hardware watchpoint.
>
> Signed-off-by: Sergey Matyukevich <sergey.matyukevich@syntacore.com>
>
> ---
>
> v1 -> v2
> - do not set tval blindly for every breakpoint exception,
> handle current specific case under consideration
>
> target/riscv/cpu_helper.c | 6 ++++++
> target/riscv/debug.c | 1 -
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng@tinylab.org>