[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 04/20] scripts/clean-includes: Improve --git commit message
From: |
Markus Armbruster |
Subject: |
[PATCH v6 04/20] scripts/clean-includes: Improve --git commit message |
Date: |
Thu, 2 Feb 2023 14:38:14 +0100 |
The script drops #include "qemu/osdep.h" from headers. Mention it in
the commit message it uses for --git.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
---
scripts/clean-includes | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/scripts/clean-includes b/scripts/clean-includes
index f0466a6262..58e1607a82 100755
--- a/scripts/clean-includes
+++ b/scripts/clean-includes
@@ -193,11 +193,17 @@ if [ "$GIT" = "yes" ]; then
git commit --signoff -F - <<EOF
$GITSUBJ: Clean up includes
-Clean up includes so that osdep.h is included first and headers
-which it implies are not included manually.
-
This commit was created with scripts/clean-includes.
+All .c should include qemu/osdep.h first. The script performs three
+related cleanups:
+
+* Ensure .c files include qemu/osdep.h first.
+* Including it in a .h is redundant, since the .c already includes
+ it. Drop such inclusions.
+* Likewise, including headers qemu/osdep.h includes is redundant.
+ Drop these, too.
+
EOF
fi
--
2.39.0
- [PATCH v6 00/20] Clean up includes, Markus Armbruster, 2023/02/02
- [PATCH v6 09/20] hw/tricore: Clean up includes, Markus Armbruster, 2023/02/02
- [PATCH v6 11/20] migration: Clean up includes, Markus Armbruster, 2023/02/02
- [PATCH v6 18/20] Don't include headers already included by qemu/osdep.h, Markus Armbruster, 2023/02/02
- [PATCH v6 08/20] hw/input: Clean up includes, Markus Armbruster, 2023/02/02
- [PATCH v6 05/20] bsd-user: Clean up includes, Markus Armbruster, 2023/02/02
- [PATCH v6 03/20] scripts/clean-includes: Skip symbolic links, Markus Armbruster, 2023/02/02
- [PATCH v6 16/20] accel: Clean up includes, Markus Armbruster, 2023/02/02
- [PATCH v6 01/20] scripts/clean-includes: Fully skip / ignore files, Markus Armbruster, 2023/02/02
- [PATCH v6 10/20] qga: Clean up includes, Markus Armbruster, 2023/02/02
- [PATCH v6 04/20] scripts/clean-includes: Improve --git commit message,
Markus Armbruster <=
- [PATCH v6 07/20] hw/cxl: Clean up includes, Markus Armbruster, 2023/02/02
- [PATCH v6 12/20] net: Clean up includes, Markus Armbruster, 2023/02/02
- [PATCH v6 17/20] Fix non-first inclusions of qemu/osdep.h, Markus Armbruster, 2023/02/02
- [PATCH v6 13/20] target/hexagon: Clean up includes, Markus Armbruster, 2023/02/02
- [PATCH v6 19/20] 9p: Drop superfluous include of linux/limits.h, Markus Armbruster, 2023/02/02
- [PATCH v6 06/20] crypto: Clean up includes, Markus Armbruster, 2023/02/02
- [PATCH v6 15/20] block: Clean up includes, Markus Armbruster, 2023/02/02
- [PATCH v6 20/20] Drop duplicate #include, Markus Armbruster, 2023/02/02
- [PATCH v6 14/20] riscv: Clean up includes, Markus Armbruster, 2023/02/02