Re: [PATCH v2 10/11] target/riscv: remove RISCV_FEATURE_MMU

[Bin Meng]

On Wed, Feb 15, 2023 at 3:27 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> RISCV_FEATURE_MMU is set whether cpu->cfg.mmu is set, so let's just use
> the flag directly instead.
>
> With this change the enum is also removed. It is worth noticing that
> this enum, and all the RISCV_FEATURES_* that were contained in it,
> predates the existence of the cpu->cfg object. Today, using cpu->cfg is
> an easier way to retrieve all the features and extensions enabled in the
> hart.
>
> Reviewed-by: Weiwei Li <liweiwei@iscas.ac.cn>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> ---
>  target/riscv/cpu.c        | 4 ----
>  target/riscv/cpu.h        | 7 -------
>  target/riscv/cpu_helper.c | 2 +-
>  target/riscv/csr.c        | 4 ++--
>  target/riscv/monitor.c    | 2 +-
>  target/riscv/pmp.c        | 2 +-
>  6 files changed, 5 insertions(+), 16 deletions(-)
>

Reviewed-by: Bin Meng <bmeng@tinylab.org>