Re: [PATCH v5 3/4] target/riscv: implement Zicbom extension

[Daniel Henrique Barboza]

On 2/15/23 19:18, Richard Henderson wrote:
> On 2/15/23 12:13, Richard Henderson wrote:
> >      ret = probe_access_flags(env, address, MMU_DATA_LOAD, mmu_idx, true, 
> > &phost, ra);
> >      if (ret != TLB_INVALID_MASK) {
> >          /* Success: readable */
> >          return;
> >      }
> ...
> > At which point the new probe_acccess_range_flags is not needed.
>
> Oh, I get it, the range is required for PMP, for sub-page range checks.
>
> I wonder how tedious it would be to adjust all callers, rather than inventing 
> yet another interface...

I took a look at the amount of tediousness involved. It's feasible to do if we
want to add a 'size' param in probe_access_flags() - existing callers would
use size = 0, RISC-V can use the appropriate size.


I'll see if I can pull it off and send it as an alternative in the next
version.


Thanks,


Daniel

> r~