[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 3/4] target/riscv: implement Zicbom extension

From: Daniel Henrique Barboza
Subject: Re: [PATCH v5 3/4] target/riscv: implement Zicbom extension
Date: Sat, 18 Feb 2023 06:51:30 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2

On 2/15/23 19:18, Richard Henderson wrote:
On 2/15/23 12:13, Richard Henderson wrote:
     ret = probe_access_flags(env, address, MMU_DATA_LOAD, mmu_idx, true, 
&phost, ra);
     if (ret != TLB_INVALID_MASK) {
         /* Success: readable */
At which point the new probe_acccess_range_flags is not needed.

Oh, I get it, the range is required for PMP, for sub-page range checks.

I wonder how tedious it would be to adjust all callers, rather than inventing 
yet another interface...

I took a look at the amount of tediousness involved. It's feasible to do if we
want to add a 'size' param in probe_access_flags() - existing callers would
use size = 0, RISC-V can use the appropriate size.

I'll see if I can pull it off and send it as an alternative in the next




reply via email to

[Prev in Thread] Current Thread [Next in Thread]