[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH RFC 0/2] s390x: cut down on unattached devices
From: |
Halil Pasic |
Subject: |
Re: [qemu-s390x] [PATCH RFC 0/2] s390x: cut down on unattached devices |
Date: |
Tue, 28 Nov 2017 15:17:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/28/2017 02:46 PM, Cornelia Huck wrote:
> info qom-tree shows several devices under unattached that probably
> should go somewhere.
I think this was reported by me. See
MID: <address@hidden>
I would not mind a Reported-by: Halil Pasic <address@hidden>.
Or do you see this differently?
If these are bugs. I would prefer commit messages and titles reflecting
this fact.
Otherwise at first glance both patches seem sane.
Regards,
Halil
>
> The css bridge should attach to the machine, as it has a similar
> purpose as e.g. a pci host bridge.
>
> The autogenerated network devices should be in the same bucket as any
> other device; I'm just not sure about the way I went about it.
>
> The zpci devices are still problematic: I don't have a good idea where
> they should show up.
>
> Remaining in the unattached container are the sysbus, memory regions
> and cpus.
>
> Cornelia Huck (2):
> s390x/css: attach css bridge
> s390x: attach autogenerated nics
>
> hw/s390x/css-bridge.c | 2 ++
> hw/s390x/s390-virtio-ccw.c | 2 ++
> 2 files changed, 4 insertions(+)
>